From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec Date: Wed, 3 Dec 2014 19:20:24 +0000 Message-ID: <20141203192024.GL7712@sirena.org.uk> References: <1417531766-29669-1-git-send-email-jay.xu@rock-chips.com> <1417591118-18695-1-git-send-email-jay.xu@rock-chips.com> <1417591118-18695-3-git-send-email-jay.xu@rock-chips.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JQobbgWnX7WjL0pQ" Return-path: Content-Disposition: inline In-Reply-To: <1417591118-18695-3-git-send-email-jay.xu@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org To: Jianqun Xu Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, sonnyrao@chromium.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org List-Id: alsa-devel@alsa-project.org --JQobbgWnX7WjL0pQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote: > From: Sonny Rao >=20 > We need to claim the clock which is driving the codec so that when we ena= ble > clock gating, we continue to clock the codec when needed. I make this an > optional clock since there might be some applications where we don't need= it > but can still use the I2S block. I would expect that the clock for the CODEC should be managed by the CODEC if at all possible - that seems more logical than having the CPU I2S controller request and manage it if it's a separate clock. Why add this to the CPU side driver? We've not always done this for older systems due to the lack of a usable clock API but that's starting to be addressed. --JQobbgWnX7WjL0pQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUf2J4AAoJECTWi3JdVIfQpDUH+QGvbqNNpYTTeH9BR7l1M2F1 Zbiy2YsxaimSZggqRO1wIKuXgiikPtNctuduDCCN9feAWkjvvh5qPfo2gTE3EMw/ p4PHfrozU/7NMhkZ4bJwneTMg2/Cs4YTMKpEYF1VD8rDZvyR4OzGswTNnJSrBX4Q bYLL0NyUb/hQUIHzAF2VAU6ffbjPXJvrAmzolEp7ujsuRq3qpRDtU8hiScaUpUG2 8sluxjAaNbtMpB6ycQUx8ImIf48z3uRLrPK8mQW8THX1d/tFBtqk2ZBI0xNSdV8T 8lowjJ2p+9y15mhDLOrOZg1N2Toh6Uo6VK/xfSFRUNYUw4FSUyDrvRHp74J3YAA= =2pcn -----END PGP SIGNATURE----- --JQobbgWnX7WjL0pQ--