From: Mark Brown <broonie@kernel.org>
To: Padma Venkat <padma.kvr@gmail.com>
Cc: alsa-devel@alsa-project.org, Padmavathi Venna <padma.v@samsung.com>
Subject: Re: [PATCH] ASoC: samsung: Fix non-DT use of I2S controller
Date: Mon, 8 Dec 2014 12:12:00 +0000 [thread overview]
Message-ID: <20141208121200.GV11764@sirena.org.uk> (raw)
In-Reply-To: <CAAgF-Bfv5OaDYu2Ti=9CCoZ9k-1ZhOG-KRfgXJYanKpLWp9ffQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]
On Mon, Dec 08, 2014 at 10:21:52AM +0530, Padma Venkat wrote:
> On 12/6/14, Mark Brown <broonie@kernel.org> wrote:
> > + }, {
> > + .name = "samsung-i2sv4",
> > + .driver_data = (kernel_ulong_t)&i2sv5_dai_type_i2s1,
> I think here you need to use i2sv5_dai_type because
> i2sv5_dai_type_i2s1 is introduced for exynos7 on which the i2s1 is of
> type v5 but with slightly modified bit offsets.
OK, though I presume that's wrong too (otherwise it should be v4).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-12-08 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 19:57 [PATCH] ASoC: samsung: Fix non-DT use of I2S controller Mark Brown
2014-12-08 4:51 ` Padma Venkat
2014-12-08 12:12 ` Mark Brown [this message]
2014-12-09 4:03 ` Padma Venkat
2014-12-10 13:19 ` Mark Brown
2014-12-12 3:23 ` Padma Venkat
2014-12-12 12:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208121200.GV11764@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox