* [PATCH] ASoC: adi: Add missing return statement.
@ 2014-12-31 16:20 Andrew Jackson
2014-12-31 16:34 ` Lars-Peter Clausen
2015-01-05 20:16 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Jackson @ 2014-12-31 16:20 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, Lars-Peter Clausen, linux-kernel, linux-arm-kernel,
Andrew Jackson
From: Andrew Jackson <Andrew.Jackson@arm.com>
The probe routine was disabling the clock even
if the system was configured successfully. Add
a return statement to leave clocks enabled.
Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
---
Spotted while reviewing clock preparation
sound/soc/adi/axi-i2s.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c
index 7752860..4c23381 100644
--- a/sound/soc/adi/axi-i2s.c
+++ b/sound/soc/adi/axi-i2s.c
@@ -240,6 +240,8 @@ static int axi_i2s_probe(struct platform_device *pdev)
if (ret)
goto err_clk_disable;
+ return 0;
+
err_clk_disable:
clk_disable_unprepare(i2s->clk);
return ret;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: adi: Add missing return statement.
2014-12-31 16:20 [PATCH] ASoC: adi: Add missing return statement Andrew Jackson
@ 2014-12-31 16:34 ` Lars-Peter Clausen
2015-01-05 20:16 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2014-12-31 16:34 UTC (permalink / raw)
To: Andrew Jackson, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: alsa-devel, linux-kernel, linux-arm-kernel
On 12/31/2014 05:20 PM, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
>
> The probe routine was disabling the clock even
> if the system was configured successfully. Add
> a return statement to leave clocks enabled.
>
> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks, never noticed since the clock is shared with other peripherals.
> ---
> Spotted while reviewing clock preparation
>
> sound/soc/adi/axi-i2s.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c
> index 7752860..4c23381 100644
> --- a/sound/soc/adi/axi-i2s.c
> +++ b/sound/soc/adi/axi-i2s.c
> @@ -240,6 +240,8 @@ static int axi_i2s_probe(struct platform_device *pdev)
> if (ret)
> goto err_clk_disable;
>
> + return 0;
> +
> err_clk_disable:
> clk_disable_unprepare(i2s->clk);
> return ret;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: adi: Add missing return statement.
2014-12-31 16:20 [PATCH] ASoC: adi: Add missing return statement Andrew Jackson
2014-12-31 16:34 ` Lars-Peter Clausen
@ 2015-01-05 20:16 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-01-05 20:16 UTC (permalink / raw)
To: Andrew Jackson
Cc: alsa-devel, Lars-Peter Clausen, Takashi Iwai, linux-kernel,
Liam Girdwood, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 286 bytes --]
On Wed, Dec 31, 2014 at 04:20:37PM +0000, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
>
> The probe routine was disabling the clock even
> if the system was configured successfully. Add
> a return statement to leave clocks enabled.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-05 20:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-31 16:20 [PATCH] ASoC: adi: Add missing return statement Andrew Jackson
2014-12-31 16:34 ` Lars-Peter Clausen
2015-01-05 20:16 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).