* [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include
@ 2015-01-06 9:21 Alexandre Belloni
2015-01-06 10:14 ` Bo Shen
2015-01-06 17:45 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Alexandre Belloni @ 2015-01-06 9:21 UTC (permalink / raw)
To: Mark Brown, Bo Shen
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
linux-arm-kernel, linux-kernel, Nicolas Ferre, Alexandre Belloni
A mach/ header is included but never used. Simply remove it.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
sound/soc/atmel/sam9g20_wm8731.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index 66b66d0e7514..531728975bbb 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -47,7 +47,6 @@
#include <sound/soc.h>
#include <asm/mach-types.h>
-#include <mach/hardware.h>
#include "../codecs/wm8731.h"
#include "atmel-pcm.h"
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include
2015-01-06 9:21 [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include Alexandre Belloni
@ 2015-01-06 10:14 ` Bo Shen
2015-01-06 11:15 ` Alexandre Belloni
2015-01-06 17:45 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Bo Shen @ 2015-01-06 10:14 UTC (permalink / raw)
To: Alexandre Belloni, Mark Brown
Cc: alsa-devel, Takashi Iwai, Nicolas Ferre, linux-kernel,
Liam Girdwood, linux-arm-kernel
Hi Alexandre Belloni,
On 01/06/2015 05:21 PM, Alexandre Belloni wrote:
> A mach/ header is included but never used. Simply remove it.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Thanks for your patch.
Acked-by: Bo Shen <voice.shen@atmel.com>
> ---
> sound/soc/atmel/sam9g20_wm8731.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 66b66d0e7514..531728975bbb 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -47,7 +47,6 @@
> #include <sound/soc.h>
>
> #include <asm/mach-types.h>
Btw, do you consider to remove this also?
> -#include <mach/hardware.h>
>
> #include "../codecs/wm8731.h"
> #include "atmel-pcm.h"
>
Best Regards,
Bo Shen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include
2015-01-06 10:14 ` Bo Shen
@ 2015-01-06 11:15 ` Alexandre Belloni
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2015-01-06 11:15 UTC (permalink / raw)
To: Bo Shen
Cc: alsa-devel, Takashi Iwai, linux-kernel, Nicolas Ferre,
Liam Girdwood, Mark Brown, linux-arm-kernel
Hi Bo,
On 06/01/2015 at 18:14:12 +0800, Bo Shen wrote :
> >
> > #include <asm/mach-types.h>
>
> Btw, do you consider to remove this also?
>
I just sent a patch for that. Feel free to squash both.
> >-#include <mach/hardware.h>
> >
> > #include "../codecs/wm8731.h"
> > #include "atmel-pcm.h"
> >
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include
2015-01-06 9:21 [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include Alexandre Belloni
2015-01-06 10:14 ` Bo Shen
@ 2015-01-06 17:45 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-01-06 17:45 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Bo Shen, Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
linux-arm-kernel, linux-kernel, Nicolas Ferre
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
On Tue, Jan 06, 2015 at 10:21:20AM +0100, Alexandre Belloni wrote:
> A mach/ header is included but never used. Simply remove it.
Applied, like I say please do use subject lines matching the style for
the subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-06 17:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-06 9:21 [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include Alexandre Belloni
2015-01-06 10:14 ` Bo Shen
2015-01-06 11:15 ` Alexandre Belloni
2015-01-06 17:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).