From: Dan Carpenter <dan.carpenter@oracle.com>
To: david.henningsson@canonical.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ALSA: hda - Enable mic mute hotkey and LEDs for an HP machine
Date: Sat, 10 Jan 2015 12:31:49 +0300 [thread overview]
Message-ID: <20150110093149.GA11804@mwanda> (raw)
Hello David Henningsson,
The patch 33f4acd3b214: "ALSA: hda - Enable mic mute hotkey and LEDs
for an HP machine" from Jan 7, 2015, leads to the following static
checker warning:
sound/pci/hda/patch_realtek.c:3551 alc280_fixup_hp_gpio2_mic_hotkey()
error: don't call input_free_device() after input_unregister_device()
sound/pci/hda/patch_realtek.c
3545 switch (action) {
3546 case HDA_FIXUP_ACT_PROBE:
3547 spec->init_amp = ALC_INIT_DEFAULT;
3548 break;
3549 case HDA_FIXUP_ACT_FREE:
3550 input_unregister_device(spec->kb_dev);
3551 input_free_device(spec->kb_dev);
I think this is a double free.
3552 spec->kb_dev = NULL;
3553 }
3554 #endif
3555 }
regards,
dan carpenter
reply other threads:[~2015-01-10 9:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150110093149.GA11804@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox