From: Mark Brown <broonie@kernel.org>
To: Oder Chiou <oder_chiou@realtek.com>
Cc: alsa-devel@alsa-project.org, yang.a.fang@intel.com,
lgirdwood@gmail.com, john.lin@realtek.com, bardliao@realtek.com,
flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5677: Add the slot_width "25" support in the TDM mode
Date: Mon, 12 Jan 2015 19:13:33 +0000 [thread overview]
Message-ID: <20150112191333.GP4160@sirena.org.uk> (raw)
In-Reply-To: <1421040895-15345-1-git-send-email-oder_chiou@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]
On Mon, Jan 12, 2015 at 01:34:55PM +0800, Oder Chiou wrote:
> Add the slot_width "25" support in the TDM mode for the Intel platform.
> case RT5677_AIF2:
> snd_soc_update_bits(codec, RT5677_TDM2_CTRL1, 0x1f00, val);
> + if (slot_width == 25)
> + snd_soc_update_bits(codec, RT5677_DIG_MISC, 0x80, 0x80);
> break;
This looks good but I'd expect to see something which clears this bit if
we're not using a slot width of 25 in case someone comes up with a use
case that changes formats at runtime (relatively unlikely, but better
safe than sorry).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2015-01-12 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 5:34 [PATCH] ASoC: rt5677: Add the slot_width "25" support in the TDM mode Oder Chiou
2015-01-12 19:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112191333.GP4160@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox