From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: "Thomas Niederprüm" <niederp@physik.uni-kl.de>
Cc: peter.ujfalusi@ti.com, alsa-devel@alsa-project.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG.
Date: Fri, 16 Jan 2015 11:09:04 +0200 [thread overview]
Message-ID: <20150116090904.GA8247@bitmer.com> (raw)
In-Reply-To: <1421360901-20671-1-git-send-email-niederp@physik.uni-kl.de>
Hi
On Thu, Jan 15, 2015 at 11:28:21PM +0100, Thomas Niederprüm wrote:
> This patch fixes faulty behaviour in a setup where the input clock for
> the SRG is fed through the CLKR pin but the McBSP is configured to be
> master (SND_SOC_DAIFMT_CBS_CFS). In that case of course CLKR must not be
> configured as output pin. Otherwise the input clock is messed up
> horribly. The same reasoning applies if CLKX is configured as input for
> the SRG.
>
> Signed-off-by: Thomas Niederprüm <niederp@physik.uni-kl.de>
> ---
> sound/soc/omap/omap-mcbsp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
I cannot check at the moment but is this actually a contradictory
configuration if McBSP is set to bit clock master but at the same want
to use it as an input also? Should you use SND_SOC_DAIFMT_CBM_CFS
instead?
Peter: care to check?
--
Jarkko
next prev parent reply other threads:[~2015-01-16 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 22:28 [PATCH] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG Thomas Niederprüm
2015-01-16 9:09 ` Jarkko Nikula [this message]
2015-01-16 9:15 ` Peter Ujfalusi
2015-01-16 10:15 ` Thomas Niederprüm
2015-01-16 12:42 ` Peter Ujfalusi
2015-01-16 15:06 ` Thomas Niederprüm
2015-01-19 7:44 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116090904.GA8247@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=niederp@physik.uni-kl.de \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).