* [PATCH] ASoC: omap-mcbsp: Correct CBM_CFS dai format configuration
@ 2015-01-16 9:20 Peter Ujfalusi
2015-01-16 9:37 ` Jarkko Nikula
2015-01-16 11:46 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2015-01-16 9:20 UTC (permalink / raw)
To: Mark Brown, Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood
We should select FSR also to be driven by McBSP, not only FSX.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Clearly the CBM_CFS is not widely used with McBSP, this is why it has not been
noticed I believe.
Peter
sound/soc/omap/omap-mcbsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 8b79cafab1e2..c7eb9dd67f60 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -434,7 +434,7 @@ static int omap_mcbsp_dai_set_dai_fmt(struct snd_soc_dai *cpu_dai,
case SND_SOC_DAIFMT_CBM_CFS:
/* McBSP slave. FS clock as output */
regs->srgr2 |= FSGM;
- regs->pcr0 |= FSXM;
+ regs->pcr0 |= FSXM | FSRM;
break;
case SND_SOC_DAIFMT_CBM_CFM:
/* McBSP slave */
--
2.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: omap-mcbsp: Correct CBM_CFS dai format configuration
2015-01-16 9:20 [PATCH] ASoC: omap-mcbsp: Correct CBM_CFS dai format configuration Peter Ujfalusi
@ 2015-01-16 9:37 ` Jarkko Nikula
2015-01-16 11:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Nikula @ 2015-01-16 9:37 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, Mark Brown, Liam Girdwood
On Fri, Jan 16, 2015 at 11:20:25AM +0200, Peter Ujfalusi wrote:
> We should select FSR also to be driven by McBSP, not only FSX.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Clearly the CBM_CFS is not widely used with McBSP, this is why it has not been
> noticed I believe.
>
> Peter
>
> sound/soc/omap/omap-mcbsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: omap-mcbsp: Correct CBM_CFS dai format configuration
2015-01-16 9:20 [PATCH] ASoC: omap-mcbsp: Correct CBM_CFS dai format configuration Peter Ujfalusi
2015-01-16 9:37 ` Jarkko Nikula
@ 2015-01-16 11:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-01-16 11:46 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, Liam Girdwood, Jarkko Nikula
[-- Attachment #1.1: Type: text/plain, Size: 147 bytes --]
On Fri, Jan 16, 2015 at 11:20:25AM +0200, Peter Ujfalusi wrote:
> We should select FSR also to be driven by McBSP, not only FSX.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-16 11:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-16 9:20 [PATCH] ASoC: omap-mcbsp: Correct CBM_CFS dai format configuration Peter Ujfalusi
2015-01-16 9:37 ` Jarkko Nikula
2015-01-16 11:46 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).