From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: arizona: Add delay for output disable
Date: Mon, 19 Jan 2015 17:13:30 +0000 [thread overview]
Message-ID: <20150119171330.GZ14516@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150119170706.GG2809@sirena.org.uk>
On Mon, Jan 19, 2015 at 05:07:06PM +0000, Mark Brown wrote:
> On Mon, Jan 19, 2015 at 04:58:50PM +0000, Charles Keepax wrote:
>
> > Similar to the power up the delay needs to be cumulative as the
> > write sequences will queue themselves up if the last one is still
> > running when the next one is started. It is fairly long for a
> > udelay I will replace with an msleep(1) instead.
>
> Given that you are needing to delay per output it's probably going to be
> better to do the coalescing of the delays - record how much delay is
> going to be needed when stopping the clock then do that at once when
> doing that. It's going to be more friendly for the rest of the system
> to see a single delay than to delay, schedule the thread again and then
> almost immediately enter another delay.
That makes sense I will look at adding that.
Thanks,
Charles
prev parent reply other threads:[~2015-01-19 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1421682586-6303-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
2015-01-19 16:24 ` [PATCH] ASoC: arizona: Add delay for output disable Mark Brown
2015-01-19 16:58 ` Charles Keepax
2015-01-19 17:07 ` Mark Brown
2015-01-19 17:13 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119171330.GZ14516@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).