From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Manuel Lauss <manuel.lauss@gmail.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: wm97xx: Reset AC'97 device before registering it
Date: Mon, 26 Jan 2015 13:14:35 +0000 [thread overview]
Message-ID: <20150126131435.GG14516@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1422026497-23180-3-git-send-email-lars@metafoo.de>
On Fri, Jan 23, 2015 at 04:21:37PM +0100, Lars-Peter Clausen wrote:
> The wm97xx touchscreen driver binds itself to the snd_ac97 device that gets
> registered by the CODEC driver and expects that the device has already been
> reset. Before commit 6794f709b712 ("ASoC: ac97: Drop delayed device
> registration") the device was only registered after the probe function of
> the CODEC driver had finished running, but starting with the mentioned
> commit the device is registered as soon as snd_soc_new_ac97_codec() is
> called. This causes the touchscreen driver to no longer work. Modify the
> CODEC drivers to use snd_soc_alloc_ac97_codec() instead of
> snd_soc_new_ac97_codec() and make sure that the AC'97 device is reset before
> the snd_ac97 device gets registered.
>
> Fixes: 6794f709b712 ("ASoC: ac97: Drop delayed device registration")
> Reported-by: Manuel Lauss <manuel.lauss@gmail.com>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Looks fine to me.
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2015-01-26 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 15:21 [PATCH 0/2] ASoC: Fix wm97xx touchscreen driver Lars-Peter Clausen
2015-01-23 15:21 ` [PATCH 1/2] ASoC: Add support for allocating AC'97 device before registering it Lars-Peter Clausen
2015-01-23 15:21 ` [PATCH 2/2] ASoC: wm97xx: Reset " Lars-Peter Clausen
2015-01-26 13:14 ` Charles Keepax [this message]
2015-01-23 19:09 ` [PATCH 0/2] ASoC: Fix wm97xx touchscreen driver Manuel Lauss
2015-01-24 13:15 ` Lars-Peter Clausen
2015-01-26 19:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126131435.GG14516@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=manuel.lauss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox