From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 2/4] ARM: mvebu: add audio I2S controller to Armada 38x Device Tree Date: Sat, 28 Feb 2015 10:58:44 +0100 Message-ID: <20150228105844.3749a825@free-electrons.com> References: <1424901482-3809-1-git-send-email-mw@semihalf.com> <1424901482-3809-3-git-send-email-mw@semihalf.com> <54EE4AD6.6090101@gmail.com> <54EE6942.9080800@gmail.com> <20150227150303.2c4ea0e7@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by alsa0.perex.cz (Postfix) with ESMTP id EE60A2602AD for ; Sat, 28 Feb 2015 10:58:48 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Marcin Wojtas Cc: Lior Amsalem , Andrew Lunn , alsa-devel@alsa-project.org, Jason Cooper , Tawfik Bayouk , Grzegorz Jaszczyk , Liam Girdwood , broonie@kernel.org, Ezequiel Garcia , Gregory =?UTF-8?B?Q2zDqW1lbnQ=?= , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth List-Id: alsa-devel@alsa-project.org Dear Marcin Wojtas, On Fri, 27 Feb 2015 21:22:30 +0100, Marcin Wojtas wrote: > Given all the facts, do you think that drivers/clk/mvebu/armada-38x.c > is a right place for adding this PLL setting support? Yes, sounds right to me. I was thinking that maybe it should be in a separate file armada-38x-pll.c, but that's probably a bit too much for something that is causing to be a simple driver. Have you sorted out how to handle the pin-muxing part of the problem? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com