* Re: ASoC: Intel: mrfld- add ACPI module
@ 2014-11-24 23:52 Dan Carpenter
2015-03-18 11:09 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2014-11-24 23:52 UTC (permalink / raw)
To: vinod.koul; +Cc: alsa-devel
Hello Vinod Koul,
The patch 336cfbb05edf: "ASoC: Intel: mrfld- add ACPI module" from
Nov 11, 2014, leads to the following static checker warning:
sound/soc/intel/sst/sst_acpi.c:313 sst_acpi_probe()
info: ignoring unreachable code.
sound/soc/intel/sst/sst_acpi.c
304 ret = sst_context_init(ctx);
305 if (ret < 0)
306 return ret;
307
308 /* need to save shim registers in BYT */
309 ctx->shim_regs64 = devm_kzalloc(ctx->dev, sizeof(*ctx->shim_regs64),
310 GFP_KERNEL);
311 if (!ctx->shim_regs64) {
312 return -ENOMEM;
^^^^^^^^^^^^^^^
313 goto do_sst_cleanup;
^^^^^^^^^^^^^^^^^^^^
314 }
315
316 sst_configure_runtime_pm(ctx);
317 platform_set_drvdata(pdev, ctx);
318 return ret;
319
320 do_sst_cleanup:
321 sst_context_cleanup(ctx);
322 platform_set_drvdata(pdev, NULL);
323 dev_err(ctx->dev, "failed with %d\n", ret);
324 return ret;
325 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: ASoC: Intel: mrfld- add ACPI module
2014-11-24 23:52 ASoC: Intel: mrfld- add ACPI module Dan Carpenter
@ 2015-03-18 11:09 ` Dan Carpenter
2015-03-18 11:15 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2015-03-18 11:09 UTC (permalink / raw)
To: vinod.koul; +Cc: alsa-devel
Ping?
regards,
dan carpenter
On Tue, Nov 25, 2014 at 02:52:09AM +0300, Dan Carpenter wrote:
> Hello Vinod Koul,
>
> The patch 336cfbb05edf: "ASoC: Intel: mrfld- add ACPI module" from
> Nov 11, 2014, leads to the following static checker warning:
>
> sound/soc/intel/sst/sst_acpi.c:313 sst_acpi_probe()
> info: ignoring unreachable code.
>
> sound/soc/intel/sst/sst_acpi.c
> 304 ret = sst_context_init(ctx);
> 305 if (ret < 0)
> 306 return ret;
> 307
> 308 /* need to save shim registers in BYT */
> 309 ctx->shim_regs64 = devm_kzalloc(ctx->dev, sizeof(*ctx->shim_regs64),
> 310 GFP_KERNEL);
> 311 if (!ctx->shim_regs64) {
> 312 return -ENOMEM;
> ^^^^^^^^^^^^^^^
> 313 goto do_sst_cleanup;
> ^^^^^^^^^^^^^^^^^^^^
> 314 }
> 315
> 316 sst_configure_runtime_pm(ctx);
> 317 platform_set_drvdata(pdev, ctx);
> 318 return ret;
> 319
> 320 do_sst_cleanup:
> 321 sst_context_cleanup(ctx);
> 322 platform_set_drvdata(pdev, NULL);
> 323 dev_err(ctx->dev, "failed with %d\n", ret);
> 324 return ret;
> 325 }
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: ASoC: Intel: mrfld- add ACPI module
2015-03-18 11:09 ` Dan Carpenter
@ 2015-03-18 11:15 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2015-03-18 11:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: alsa-devel
On Wed, Mar 18, 2015 at 02:09:32PM +0300, Dan Carpenter wrote:
> Ping?
Sory dan, this seems to have slipped thru, I will send the patch for this.
Thanks a bunch for reporting
--
~Vinod
>
> regards,
> dan carpenter
>
> On Tue, Nov 25, 2014 at 02:52:09AM +0300, Dan Carpenter wrote:
> > Hello Vinod Koul,
> >
> > The patch 336cfbb05edf: "ASoC: Intel: mrfld- add ACPI module" from
> > Nov 11, 2014, leads to the following static checker warning:
> >
> > sound/soc/intel/sst/sst_acpi.c:313 sst_acpi_probe()
> > info: ignoring unreachable code.
> >
> > sound/soc/intel/sst/sst_acpi.c
> > 304 ret = sst_context_init(ctx);
> > 305 if (ret < 0)
> > 306 return ret;
> > 307
> > 308 /* need to save shim registers in BYT */
> > 309 ctx->shim_regs64 = devm_kzalloc(ctx->dev, sizeof(*ctx->shim_regs64),
> > 310 GFP_KERNEL);
> > 311 if (!ctx->shim_regs64) {
> > 312 return -ENOMEM;
> > ^^^^^^^^^^^^^^^
> > 313 goto do_sst_cleanup;
> > ^^^^^^^^^^^^^^^^^^^^
> > 314 }
> > 315
> > 316 sst_configure_runtime_pm(ctx);
> > 317 platform_set_drvdata(pdev, ctx);
> > 318 return ret;
> > 319
> > 320 do_sst_cleanup:
> > 321 sst_context_cleanup(ctx);
> > 322 platform_set_drvdata(pdev, NULL);
> > 323 dev_err(ctx->dev, "failed with %d\n", ret);
> > 324 return ret;
> > 325 }
> >
> > regards,
> > dan carpenter
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-18 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 23:52 ASoC: Intel: mrfld- add ACPI module Dan Carpenter
2015-03-18 11:09 ` Dan Carpenter
2015-03-18 11:15 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).