From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v2 7/7] ASoC: hda - added Skylake I2S machine driver Date: Sat, 18 Apr 2015 00:36:55 +0530 Message-ID: <20150417190655.GO30624@intel.com> References: <1429262000-21517-1-git-send-email-vinod.koul@intel.com> <1429262000-21517-8-git-send-email-vinod.koul@intel.com> <5530D612.4000109@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by alsa0.perex.cz (Postfix) with ESMTP id 63E6226061E for ; Fri, 17 Apr 2015 21:12:06 +0200 (CEST) Content-Disposition: inline In-Reply-To: <5530D612.4000109@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org, tiwai@suse.de, lgirdwood@gmail.com, Omair M Abdullah , broonie@kernel.org, Jeeja KP List-Id: alsa-devel@alsa-project.org On Fri, Apr 17, 2015 at 11:44:50AM +0200, Lars-Peter Clausen wrote: > On 04/17/2015 11:13 AM, Vinod Koul wrote: > [...] > >+ /* always connected - check HP for jack detect */ > >+ snd_soc_dapm_enable_pin(dapm, "Headphone Jack"); > >+ snd_soc_dapm_enable_pin(dapm, "Speaker"); > >+ snd_soc_dapm_enable_pin(dapm, "Mic Jack"); > >+ snd_soc_dapm_enable_pin(dapm, "DMIC2"); > > There is no need to do this, all pins are enabled by default. Ah yes, thanks for pointing. With this I should also set full_routed right? -- ~Vinod