Re: [PATCH 1/7] ASoC: sti: add binding for ASoc driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1121 bytes --]

On Tue, Apr 14, 2015 at 03:35:25PM +0200, Arnaud Pouliquen wrote:

> Add Asoc driver bindings documentation.

ASoC.

> +- cpu-dai: sti-asoc-platform subnode that describes properties for a CPU-DAI instance.
> +Required properties:
> +  - dai-name: DAI name that describes the IP.
> +  - dai-type: DAI functionality.
> +	"uni-player" for playback.
> +	"uni-reader" for capture.

It would be more idiomatic to do this with eithe ra commpatible string
or a specifically named node.

> +Optional properties:
> +  - standby:  standby mode activation deactivation. this mode is specific to
> +	      Uni player IP and allows to transmit bus clock and a pattern data
> +	      while audio stream is stopped or paused.

I'm not entirely sure what the above means but it sounds like some
software configuration rather than a property of the hardware?  Or do
some variants of the IP lack this functionality?

> +  - auto-suspend-delay: runtime auto suspend delay (in ms) before deactivating
> +			stanby mode. Equivalent to the DAPM mechanism but for
> +			CPU DAI.

DAPM works perfectly well for on SoC components, please use it.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]