From: Vinod Koul <vinod.koul@intel.com>
To: Yang Fang <yang.a.fang@intel.com>
Cc: alsa-devel@alsa-project.org, praveen.k.jain@intel.com,
praveen.diwakar@intel.com, lgirdwood@gmail.com,
denny.iriawan@intel.com, broonie@kernel.org,
kevin.strasser@linux.intel.com, dgreid@chromium.org
Subject: Re: [PATCH 2/4] ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090
Date: Fri, 1 May 2015 10:14:16 +0530 [thread overview]
Message-ID: <20150501044416.GS3521@localhost> (raw)
In-Reply-To: <20150430062418.GA76535@mocha>
On Wed, Apr 29, 2015 at 11:24:18PM -0700, Yang Fang wrote:
> > > + /* back ends */
> > > + {
> > > + .name = "SSP2-Codec",
> > > + .be_id = 1,
> > > + .cpu_dai_name = "ssp2-port",
> > > + .platform_name = "sst-mfld-platform",
> > > + .no_pcm = 1,
> > > + .codec_dai_name = "HiFi",
> > > + .codec_name = "i2c-193C9890:00",
> > > + .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
> > > + | SND_SOC_DAIFMT_CBS_CFS,
> > > + .init = cht_codec_init,
> > > + .be_hw_params_fixup = cht_codec_fixup,
> > > + .nonatomic = true,
> > this doesnt make sense for BEs
> this is taking the fix from below commit for another braswell machine driver
>
Thanks for pinting, it makes sense for FE dailinks where trigger ops are
invoked. Not for BE dailinks. I will get it removed from BE one
--
~Vinod
next prev parent reply other threads:[~2015-05-01 4:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 1:43 [PATCH 1/4] ASoC: Intel: Add support max98090 in sst driver yang.a.fang
2015-04-30 1:43 ` [PATCH 2/4] ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090 yang.a.fang
2015-04-30 4:36 ` Vinod Koul
2015-04-30 6:24 ` Yang Fang
2015-04-30 15:40 ` Pierre-Louis Bossart
2015-04-30 16:39 ` Dylan Reid
2015-04-30 18:30 ` Pierre-Louis Bossart
2015-04-30 17:43 ` Fang, Yang A
2015-05-01 4:44 ` Vinod Koul [this message]
2015-04-30 20:15 ` Mark Brown
2015-04-30 20:19 ` Mark Brown
2015-05-01 18:42 ` [PATCH v2 1/2] ASoC: Intel: Add support max98090 in sst driver yang.a.fang
2015-05-01 18:42 ` [PATCH v2 2/2] ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090_ti yang.a.fang
2015-05-04 12:17 ` Mark Brown
2015-05-04 14:40 ` Fang, Yang A
2015-05-04 17:14 ` Mark Brown
2015-05-04 12:16 ` [PATCH v2 1/2] ASoC: Intel: Add support max98090 in sst driver Mark Brown
2015-04-30 1:43 ` [PATCH 3/4] ASoC: ts3a227e: add platform data for ts3a227e driver yang.a.fang
2015-04-30 20:02 ` Mark Brown
2015-04-30 20:45 ` Fang, Yang A
2015-04-30 21:25 ` Mark Brown
2015-04-30 1:43 ` [PATCH 4/4] ASoC: ts3a227e: set irq flag base on dmi yang.a.fang
2015-04-30 17:45 ` Dylan Reid
2015-04-30 20:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501044416.GS3521@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=denny.iriawan@intel.com \
--cc=dgreid@chromium.org \
--cc=kevin.strasser@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=praveen.diwakar@intel.com \
--cc=praveen.k.jain@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).