Re: [PATCH 2/2] ASoC: zx: Add zx296702 SPDIF support

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1420 bytes --]

On Tue, May 05, 2015 at 09:43:56AM +0800, Jun Nie wrote:
> 2015-05-04 21:54 GMT+08:00 Mark Brown <broonie@kernel.org>:

> > So this special HDMI S/PDIF controller is directly integrated with the
> > HDMI IP in the SoC and not usable as a generic S/PDIF controller?  That
> > seems to mirror system designs which have an external HDMI encoder which
> > use S/PDIF or I2S to connect the audio portion to an external device.

> The first SPDIF controller on ZTE SOC is dedicated for HDMI and the
> 2nd one is for external output only via physical pad. The two
> controller IPs are identical, also independent with each other and
> HDMI in register address region.

OK, so this does sound like the software should like one of the systems
with an external HDMI encoder and the HDMI handled separately rather
than in this driver anyway.

> > I'd suggest for future versions reorganizing things so that you add the
> > S/PDIF driver with only S/PDIF support and then have a separate patch
> > that layers on the HDMI support.

> Reasonable suggestion. Then I can have more time to think about HDMI
> part. More comments is welcome if any.

This sounds like the software should look like a TDA998x (which is
having patches posted still) so just have the S/PDIF controllers as pure
S/PDIF controllers and then a separate driver for the HDMI part that
it's hooked up to which deals with the audio configuration for the HDMI
side.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]