From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Wong Subject: Re: [PATCH 2/2] sound/usb: Update ALSA driver to use media controller API Date: Sat, 9 May 2015 04:51:09 +0000 Message-ID: <20150509045109.GA6528@dcvr.yhbt.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org To: Shuah Khan Cc: mchehab@osg.samsung.com, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, tiwai@suse.de, perex@perex.cz, agoode@google.com, pierre-louis.bossart@linux.intel.com, gtmkramer@xs4all.nl, clemens@ladisch.de, vladcatoi@gmail.com, damien@zamaudio.com, chris.j.arges@canonical.com, takamichiho@gmail.com, misterpib@gmail.com, daniel@zonque.org, pmatilai@laiskiainen.org, jussi@sonarnerd.net, fisch602@gmail.com, joe@oampo.co.uk, linux-media@vger.kernel.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Shuah Khan wrote: > @@ -541,13 +591,19 @@ int snd_usb_create_quirk(struct snd_usb_audio *chip, > [QUIRK_AUDIO_ALIGN_TRANSFER] = create_align_transfer_quirk, > [QUIRK_AUDIO_STANDARD_MIXER] = create_standard_mixer_quirk, > }; > + int ret; > > + if (quirk->media_device) { > + /* don't want to fail when media_device_init() doesn't work */ > + ret = media_device_init(iface); > + } > if (quirk->type < QUIRK_TYPE_COUNT) { > - return quirk_funcs[quirk->type](chip, iface, driver, quirk); > + ret = quirk_funcs[quirk->type](chip, iface, driver, quirk); > } else { > usb_audio_err(chip, "invalid quirk type %d\n", quirk->type); > return -ENXIO; > } > + return ret; > } What is the point of saving 'ret' of media_device_init if it'll only be clobbered or ignored for ENXIO?