From: Mark Brown <broonie@kernel.org>
To: zhengxing <zhengxing@rock-chips.com>
Cc: Xing Zheng <acgzxing@gmail.com>,
dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de,
sonnyrao@chromium.org, linux-rockchip@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for max98090
Date: Wed, 13 May 2015 17:47:38 +0100 [thread overview]
Message-ID: <20150513164738.GC2761@sirena.org.uk> (raw)
In-Reply-To: <55535048.4030703@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Wed, May 13, 2015 at 09:23:20PM +0800, zhengxing wrote:
> On 2015年05月13日 03:26, Mark Brown wrote:
> >This looks more like a normal and reasonable machine driver but then why
> >have you created the generic rockchip machine driver? It seems like
> >this should just be a regular machine driver like other platforms have,
> >were it not for that this would be mostly fine apart from a couple of
> >nitpicks below.
> We just use rockchip_machine_driver to describe the supported codecs base on
> origianl way, vendor machine driver(rockchip_max98090) will achieve
> functions.
Like I said in reply to the other message I just don't understand what
you're saying here - take a look at the various Tegra machine drivers
for example, they also have per-CODEC handling but they just use normal
machine drivers to do it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-13 16:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 9:26 [PATCH 0/4] ASoC: rockchip: add rockchip machine driver Xing Zheng
2015-05-12 9:26 ` [PATCH 1/4] " Xing Zheng
2015-05-12 19:22 ` Mark Brown
2015-05-13 13:23 ` zhengxing
2015-05-13 16:42 ` Mark Brown
2015-05-13 17:21 ` Dylan Reid
2015-05-13 23:11 ` Dylan Reid
2015-05-14 2:22 ` zhengxing
2015-05-15 20:40 ` [alsa-devel] " Lars-Peter Clausen
2015-05-19 11:16 ` Mark Brown
2015-05-19 16:37 ` [alsa-devel] " Dylan Reid
2015-05-21 11:10 ` Mark Brown
2015-05-12 9:26 ` [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for max98090 Xing Zheng
2015-05-12 19:26 ` Mark Brown
2015-05-13 13:23 ` zhengxing
2015-05-13 16:47 ` Mark Brown [this message]
2015-05-12 9:26 ` [PATCH 3/4] ASoC: rockchip: add rockchip machine driver for rt5650/rt5645 Xing Zheng
2015-05-12 19:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513164738.GC2761@sirena.org.uk \
--to=broonie@kernel.org \
--cc=acgzxing@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=sonnyrao@chromium.org \
--cc=tiwai@suse.de \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox