From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Alexandre Courbot <gnurou@gmail.com>,
alsa-devel@alsa-project.org,
Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ASoC: rx51: use flags argument of devm_gpiod_get to set direction
Date: Tue, 19 May 2015 11:16:50 +0300 [thread overview]
Message-ID: <20150519081650.GA8310@bitmer.com> (raw)
In-Reply-To: <1432021688-25830-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Tue, May 19, 2015 at 09:48:08AM +0200, Uwe Kleine-König wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
>
> Use this to simplify the driver. Furthermore this is one caller less
> that stops us making the flags argument to gpiod_get*() mandatory.
>
> Fixes: 386e81ab3b4d ("ASoC: omap: rx51: get GPIO numbers via gpiod API")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> sound/soc/omap/rx51.c | 30 ++++++++----------------------
> 1 file changed, 8 insertions(+), 22 deletions(-)
>
I don't think Fixes tag is justified. Otherwise than that
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com
next prev parent reply other threads:[~2015-05-19 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 7:48 [PATCH] ASoC: rx51: use flags argument of devm_gpiod_get to set direction Uwe Kleine-König
2015-05-19 8:16 ` Jarkko Nikula [this message]
2015-05-19 10:44 ` Mark Brown
2015-05-19 12:10 ` Uwe Kleine-König
2015-05-20 18:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519081650.GA8310@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sre@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).