From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] ASoC: rx51: use flags argument of devm_gpiod_get to set direction Date: Tue, 19 May 2015 11:16:50 +0300 Message-ID: <20150519081650.GA8310@bitmer.com> References: <1432021688-25830-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from bitmer.com (bitmer.com [213.157.87.50]) by alsa0.perex.cz (Postfix) with ESMTP id A8C912606E1 for ; Tue, 19 May 2015 10:16:59 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1432021688-25830-1-git-send-email-u.kleine-koenig@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Alexandre Courbot , alsa-devel@alsa-project.org, Linus Walleij , Liam Girdwood , Sebastian Reichel , Peter Ujfalusi , Mark Brown , kernel@pengutronix.de, linux-omap@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Tue, May 19, 2015 at 09:48:08AM +0200, Uwe Kleine-K=F6nig wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > = > Use this to simplify the driver. Furthermore this is one caller less > that stops us making the flags argument to gpiod_get*() mandatory. > = > Fixes: 386e81ab3b4d ("ASoC: omap: rx51: get GPIO numbers via gpiod API") > Signed-off-by: Uwe Kleine-K=F6nig > --- > sound/soc/omap/rx51.c | 30 ++++++++---------------------- > 1 file changed, 8 insertions(+), 22 deletions(-) > = I don't think Fixes tag is justified. Otherwise than that Acked-by: Jarkko Nikula