From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
kernel@pengutronix.de, Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH] ASoC: rx51: use flags argument of devm_gpiod_get to set direction
Date: Tue, 19 May 2015 14:10:05 +0200 [thread overview]
Message-ID: <20150519121005.GD24769@pengutronix.de> (raw)
In-Reply-To: <20150519104458.GF2761@sirena.org.uk>
On Tue, May 19, 2015 at 11:44:58AM +0100, Mark Brown wrote:
> On Tue, May 19, 2015 at 11:16:50AM +0300, Jarkko Nikula wrote:
>
> > I don't think Fixes tag is justified. Otherwise than that
>
> Yes, I don't see any bug fixing here - am I missing something?
It only becomes a bug once the flags parameter becomes mandatory. But
right, currently it's not a bug, just inefficient use of the gpiod
stuff.
Feel free to drop the Fixes: on application.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-19 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 7:48 [PATCH] ASoC: rx51: use flags argument of devm_gpiod_get to set direction Uwe Kleine-König
2015-05-19 8:16 ` Jarkko Nikula
2015-05-19 10:44 ` Mark Brown
2015-05-19 12:10 ` Uwe Kleine-König [this message]
2015-05-20 18:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519121005.GD24769@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).