From: Mark Brown <broonie@kernel.org>
To: Jun Nie <jun.nie@linaro.org>
Cc: alsa-devel@alsa-project.org, shawn.guo@linaro.org,
wan.zhijun@zte.com.cn, lgirdwood@gmail.com,
zte-lt@lists.linaro.org
Subject: Re: [PATCH v2 2/3] ASoC: zx: Add zx296702 SPDIF support
Date: Fri, 22 May 2015 13:09:14 +0100 [thread overview]
Message-ID: <20150522120914.GI21391@sirena.org.uk> (raw)
In-Reply-To: <1430915885-30656-2-git-send-email-jun.nie@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 262 bytes --]
On Wed, May 06, 2015 at 08:38:04PM +0800, Jun Nie wrote:
> Add driver for zx296702 SPDIF controller
This all seems fine apart from the fact that you're adding a new DT
binding with no binding documentation - all new DT binndings require
binnding documentation.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-22 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430915885-30656-1-git-send-email-jun.nie@linaro.org>
2015-05-18 8:04 ` [PATCH v2 1/3] ASoC: zx: Add ZTE zx296702 pcm support Jun Nie
2015-05-21 20:04 ` Mark Brown
2015-05-22 1:08 ` Jun Nie
2015-05-22 11:35 ` Mark Brown
2015-05-23 14:41 ` Jun Nie
2015-05-22 12:07 ` Mark Brown
[not found] ` <1430915885-30656-2-git-send-email-jun.nie@linaro.org>
2015-05-22 12:09 ` Mark Brown [this message]
[not found] ` <1430915885-30656-3-git-send-email-jun.nie@linaro.org>
2015-05-22 12:10 ` [PATCH v2 3/3] dt: Add documentation for the ZTE SPDIF controller Mark Brown
2015-05-23 14:04 ` Jun Nie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522120914.GI21391@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jun.nie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=wan.zhijun@zte.com.cn \
--cc=zte-lt@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox