Re: [PATCH v4 0/7] ASoC: intel - add skylake PCM driver

[Vinod Koul <vinod.koul@intel.com>]

On Mon, May 25, 2015 at 01:58:58PM +0200, Takashi Iwai wrote:
> > > Merging this without the codec driver would be rather confusing for
> > > users, since it gives a conflicting driver that doesn't work at all.
> > > I suppose that the merge should be pending until the complete
> > > implementation of ASoC HDA.
> > Well users wont notice till we have a machine driver which selects this
> > driver. That is why machine driver will come last and needs to be
> > merged only after controller and codec drivers are merged for end
> > users to notice
> 
> We still don't provide a way to lead to the right driver.  With your
> patch 5, it creates another SKL PCI driver that conflicts with the
> existing driver entry of snd-hda-intel.  So, at this moment, it just
> give a conflict for non-working driver, and it's not good to leave so
> unless the complete driver set is provided in a week or so.
Hi Takashi,

You are right in that but the point is that user cannot select this driver

+config SND_SOC_INTEL_HDA_SKYLAKE
+       tristate
+       select SND_SOC_HDA_CORE
+       help
+         Say Y here to include support for ASoC Intel "High Definition
+         Audio" (Skylake) and its compatible devices.

So unless someone selects this symbol (machine driver) it wont be built for
anyone (expect you and me to test :D ) and wont conflict.
Or did I miss something ?

Also anyway I will add the flag in this driver as follow on to disable
registering this device so that users don't see this device getting
registered, unless we have complete story merged.

Thanks
-- 
~Vinod