From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask Date: Tue, 26 May 2015 10:44:22 +0100 Message-ID: <20150526094422.GI21577@sirena.org.uk> References: <5560AB9D.1010807@maciej.szmigiero.name> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5682221619159809832==" Return-path: Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 473DD2614A9 for ; Tue, 26 May 2015 11:44:38 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: "Maciej S. Szmigiero" , Lars-Peter Clausen , Matt Reimer , "alsa-devel@alsa-project.org" , Wolfram Sang , linux-kernel , patches@opensource.wolfsonmicro.com, Liam Girdwood , Charles Keepax , Daniel Mack List-Id: alsa-devel@alsa-project.org --===============5682221619159809832== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="67L3nkltNbzPAvlZ" Content-Disposition: inline --67L3nkltNbzPAvlZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 26, 2015 at 07:29:57AM +0200, Takashi Iwai wrote: > Maciej S. Szmigiero wrote: > > Found out by sparse on 0-day kernel tester. > Wow, that made me wonder how these drivers could actually work. AFAICT the bits were being set by being ored in from the sequential values. > BTW, how did you detect it? Any static analyzer like sparse or > smatch? sparse didn't detect it at the last time I tried, IIRC... Commit log says sparse. --67L3nkltNbzPAvlZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZEB1AAoJECTWi3JdVIfQoYAH/R8qifIhxg3A7I0iS21tnnW6 lRp2JcWBHWY/2zF2cn9jl9ocVC2SGqA+VUXcA6NkduSSwUWuQzqK9frmaIG2I1Sk hYh1faw1b4f2J1gDSWYxxRbVFy0HZTtUbQYwXkybhVpOjilg2PRMJSJ4bYQJbEe4 KvCH6t+WNwd2KYrtxfitJHNyrHG2xNEOcG/q05VceZmqCQYan652K6iROaRPzd+B UbMwSIyWyISnAT0XBjDdXsPcnkCeWpREX0bSDSOsvRQLe3wuQXSpPHtKYxJp1KBM jQbbCU9QN0oH963Om0rNGzKTjomb/jImX9KWejD/Y6KTvQ+xuK92fOnyxtYxMNg= =vLCk -----END PGP SIGNATURE----- --67L3nkltNbzPAvlZ-- --===============5682221619159809832== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============5682221619159809832==--