From: Mark Brown <broonie@kernel.org>
To: Dylan Reid <dgreid@chromium.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lars@metafoo.de,
lgirdwood@gmail.com, zhengxing@rock-chips.com
Subject: Re: [PATCH v2] ASoC: Add GPIO based jack device
Date: Tue, 26 May 2015 23:10:34 +0100 [thread overview]
Message-ID: <20150526221034.GC21577@sirena.org.uk> (raw)
In-Reply-To: <1432661622-4901-1-git-send-email-dgreid@chromium.org>
[-- Attachment #1.1: Type: text/plain, Size: 734 bytes --]
On Tue, May 26, 2015 at 10:33:42AM -0700, Dylan Reid wrote:
> +Required properties:
> +
> +- compatible : "linux,gpio-audio-jack"
As mentioned in the discussion of v1 I think we should drop gpio- from
this - Lars is right that we should really be more generic and there's
no reason this can't serve as a non-GPIO jack especially given that...
> +
> +Optional properties:
> +
> +- gpio-audio-jack,jack-name : Name of the jack. Normally
> + 'Headphone Jack', 'Mic Jack', or
> + 'Headset Jack'
> +- gpio-audio-jack,sw-det-gpios : Reference to GPIOs that signals when
> + a jack is plugged.
...GPIOs are optional anyway! However I think Lars had further concerns
about abstraction which I seem to have missed.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2015-05-26 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 17:33 [PATCH v2] ASoC: Add GPIO based jack device Dylan Reid
2015-05-26 22:10 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526221034.GC21577@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dgreid@chromium.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox