Re: [PATCH v4 3/7] ASoC: hda - add asoc hda core bus, controller and stream helpers

[Vinod Koul <vinod.koul@intel.com>]

On Tue, May 26, 2015 at 07:51:51PM +0100, Mark Brown wrote:
> On Mon, May 11, 2015 at 04:24:01PM +0530, Vinod Koul wrote:
> 
> > +#ifndef __SOUND_SOC_HDAUDIO_H
> > +#define __SOUND_SOC_HDAUDIO_H
> > +
> > +#include <sound/core.h>
> > +#include <sound/initval.h>
> > +#include <sound/hda_register.h>
> > +#include <sound/hdaudio.h>
> 
> ...
> 
> > +#include <linux/kernel.h>
> > +#include <linux/delay.h>
> > +#include <linux/export.h>
> > +#include <linux/module.h>
> > +#include <linux/slab.h>
> > +#include <sound/core.h>
> > +#include <sound/soc-hdaudio.h>
> 
> ...
> 
> > +#include <linux/kernel.h>
> > +#include <linux/delay.h>
> > +#include <linux/export.h>
> > +#include <sound/core.h>
> > +#include <sound/pcm.h>
> > +#include <sound/hdaudio.h>
> > +#include <sound/hda_register.h>
> > +#include <sound/soc-hdaudio.h>
> 
> This includes no ASoC specific headers, what is ASoC specific about it?
Hi Mark,

This patch adds the hda helpers for enhanced capability added in SKL
HDA and these are not part of base HDA specification.

So we kept it out of Intel/ dir code as these and further enhancements can
be added/used by other vendors too..

Thanks
-- 
~Vinod