From: Mark Brown <broonie@kernel.org>
To: Ben Zhang <benzh@chromium.org>
Cc: Omair Mohammed Abdullah <omair.m.abdullah@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Dylan Reid <dgreid@chromium.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks
Date: Wed, 3 Jun 2015 12:59:51 +0100 [thread overview]
Message-ID: <20150603115951.GG14071@sirena.org.uk> (raw)
In-Reply-To: <1433283843-33856-1-git-send-email-benzh@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Tue, Jun 02, 2015 at 03:24:03PM -0700, Ben Zhang wrote:
> - int (*get)(unsigned int __user *bytes, unsigned int size);
> - int (*put)(const unsigned int __user *bytes, unsigned int size);
> + int (*get)(struct snd_kcontrol *kcontrol,
> + unsigned int __user *bytes, unsigned int size);
> + int (*put)(struct snd_kcontrol *kcontrol,
> + const unsigned int __user *bytes, unsigned int size);
This doesn't update any users and we do have some like the Haswell PCM
driver.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-03 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 22:24 [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks Ben Zhang
2015-06-03 11:59 ` Mark Brown [this message]
2015-06-03 21:10 ` Ben Zhang
2015-06-12 11:22 ` Mark Brown
2015-06-12 7:30 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603115951.GG14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=benzh@chromium.org \
--cc=dgreid@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omair.m.abdullah@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox