From: Mark Brown <broonie@kernel.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
john.lin@realtek.com, Bard Liao <bardliao@realtek.com>,
flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5677: Avoid recursive locking in the DEADLOCK detector
Date: Fri, 5 Jun 2015 11:31:44 +0100 [thread overview]
Message-ID: <20150605103144.GS14071@sirena.org.uk> (raw)
In-Reply-To: <CANMq1KCFwFppzAx5NiotP_0uy93Ga436PYEbhhA6iM0JCXWtaA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 809 bytes --]
On Fri, Jun 05, 2015 at 08:53:54AM +0800, Nicolas Boichat wrote:
> > Could you be more specific about the deadlock you're seeing? This isn't
> > really enough to understand either what the problem is or why this fixes
> > it. Converting all the per-regmap mutexes into a single global mutex
> > isn't an immediately obvious step.
> We originally reported the issue to Realtek:
Any analysis needs to be in the changelog for the commit and...
> I suggested reworking the register read/write calls in rt5677.c to
> direct them to the correct regmap earlier on (rt5677->regmap or
> rt5677->regmap_physical), before locks are acquired. But the patch
> above also fixes the issue (that is, it removes the warning).
...the above sounds like there's a bug in the locking anyway which this
is just a bodge for?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-06-05 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 15:53 [PATCH] ASoC: rt5677: Avoid recursive locking in the DEADLOCK detector Oder Chiou
2015-06-03 16:44 ` Mark Brown
2015-06-05 0:53 ` Nicolas Boichat
2015-06-05 10:31 ` Mark Brown [this message]
2015-06-05 10:53 ` Lars-Peter Clausen
2015-06-05 17:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605103144.GS14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=drinkcat@chromium.org \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox