From: Sergey Kiselev <sergey.kiselev@intel.com>
To: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: wm8731 - redundant register initialization, stream name vs DAPM widgets, snd_soc_io to regmap_io conversion
Date: Fri, 5 Jun 2015 12:27:48 -0700 [thread overview]
Message-ID: <20150605122748.b7534fc4900573ed497928ce@intel.com> (raw)
Hi,
I have a few questions regarding wm8731. Some might be applicable to other
codecs as well.
1. According to the datasheet bit #8 of all the registers below is set to
'0' by the hardware reset. Is there a good reason to set them anyway?
(Perhaps an errata in previous chip version?)
/* Latch the update bits */
snd_soc_update_bits(codec, WM8731_LOUT1V, 0x100, 0);
snd_soc_update_bits(codec, WM8731_ROUT1V, 0x100, 0);
snd_soc_update_bits(codec, WM8731_LINVOL, 0x100, 0);
snd_soc_update_bits(codec, WM8731_RINVOL, 0x100, 0);
2. In wm8731's snd_soc_dai_driver structure the steam names are 'Playback'
and 'Capture', while DAPM widgets have 'HiFi' prepended to the names:
SND_SOC_DAPM_DAC("DAC", "HiFi Playback", WM8731_PWR, 3, 1),
SND_SOC_DAPM_ADC("ADC", "HiFi Capture", WM8731_PWR, 2, 1),
Should the name match? DAPM.txt says so, but the DAPM code actually looks
for a substring match (DAI name as a substring in widget name).
3. Do I understand correctly the direction is to move from snd_soc_${io}
to more generic regmap_${io}? If so, I'll submit a patch.
Thanks
--
Sergey
next reply other threads:[~2015-06-05 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 19:27 Sergey Kiselev [this message]
2015-06-08 9:51 ` wm8731 - redundant register initialization, stream name vs DAPM widgets, snd_soc_io to regmap_io conversion Charles Keepax
2015-06-09 18:24 ` Lars-Peter Clausen
2015-06-09 18:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605122748.b7534fc4900573ed497928ce@intel.com \
--to=sergey.kiselev@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=liam.r.girdwood@linux.intel.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox