From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v6 1/3] ALSA: hdac_ext: add extended HDA bus
Date: Tue, 9 Jun 2015 15:36:51 +0530
Message-ID: <20150609100651.GT28601@localhost>
References: <1433411602-5444-1-git-send-email-vinod.koul@intel.com>
 <1433411602-5444-2-git-send-email-vinod.koul@intel.com>
 <s5hh9qik21f.wl-tiwai@suse.de> <20150608100822.GC28601@localhost>
 <20150608153014.GN28601@localhost> <s5hmw0aqkch.wl-tiwai@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by alsa0.perex.cz (Postfix) with ESMTP id BD3EC26065C
 for <alsa-devel@alsa-project.org>; Tue,  9 Jun 2015 12:05:28 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <s5hmw0aqkch.wl-tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Takashi Iwai <tiwai@suse.de>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>
List-Id: alsa-devel@alsa-project.org

On Mon, Jun 08, 2015 at 05:40:46PM +0200, Takashi Iwai wrote:
> At Mon, 8 Jun 2015 21:00:14 +0530,
> Vinod Koul wrote:
> > 
> > On Mon, Jun 08, 2015 at 03:38:22PM +0530, Vinod Koul wrote:
> > > > > +#define snd_hdac_ext_bus_ppcap_updateb(dev, reg, mask, val) \
> > > > > +	snd_hdac_ext_bus_ppcap_writeb(dev, reg, \
> > > > > +			       (snd_hdac_ext_bus_ppcap_readb(dev, reg) & \
> > > > > +				~(mask)) | (val))
> > > > 
> > > > It's not necessarily good to wrap all with such macros.
> > > > For azx_write*(), I kept them as is for reducing the amount of useless
> > > > code rewrites.  But for new codes, I don't think it's always worth...
> > > Actually while updating the patch for ext I was wondering about this too.
> > > 
> > > So we cna remove these and use snd_hdac_chip_writel/w/b here
> > As Jeeja pointed we can't use snd_hdac_chip_writel as we need to use a
> > different base. So we cna move this to use plain writel only
> > 
> > Any other ideas?
> 
> I don't think you need to access via io_ops redirection as these are
> SKL specific registers.  Use plain readl()/writel() and keep things
> as simple as possible.
> 
> (And better to avoid w and b variants.)
Okay I have removed all these macros but ended up defining one generic update
macros (most of the places we are doing read and write, so better to use
update macro

/* update register macro */
#define snd_hdac_updatel(addr, reg, mask, val) \
	writel(addr, reg, (readl(addr, reg) & ~(mask)) | (val))

yes its updatel to signify that it uses writel and readl

Let me know if you are fine with this approach

-- 
~Vinod