From: Mark Brown <broonie@kernel.org>
To: Zidan Wang <zidan.wang@freescale.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
ckeepax@opensource.wolfsonmicro.com, lars@metafoo.de,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel][PATCH 1/4] ASoC: wm8960: codec mclk should be enabled early to avoid jack detect error
Date: Fri, 12 Jun 2015 11:33:49 +0100 [thread overview]
Message-ID: <20150612103349.GE1921@sirena.org.uk> (raw)
In-Reply-To: <20150612063231.GA23608@shlinux2>
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Fri, Jun 12, 2015 at 02:32:33PM +0800, Zidan Wang wrote:
> I have done some test today, and found that after mclk enable, we should delay
> at least 150ms to prepare the jack detect function. So no need to move mclk
> enable to startup.
No, this makes no sense - jack detection is not related to playback at
all. The system should be able to detect if something is connected at
any time. What this says is that you need to keep MCLK enabled while
jack detection is available.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-12 10:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1434020423.git.zidan.wang@freescale.com>
2015-06-11 11:14 ` [alsa-devel][PATCH 1/4] ASoC: wm8960: codec mclk should be enabled early to avoid jack detect error Zidan Wang
2015-06-11 16:20 ` Mark Brown
2015-06-12 6:32 ` Zidan Wang
2015-06-12 10:33 ` Mark Brown [this message]
2015-06-16 9:30 ` Zidan Wang
2015-06-11 11:14 ` [alsa-devel][PATCH 2/4] ASoC: wm8960: support configure headphone jack detect pin and polarity from device tree Zidan Wang
2015-06-12 12:50 ` [PATCH " Charles Keepax
2015-06-16 7:47 ` [alsa-devel][PATCH " Zidan Wang
2015-06-11 11:14 ` [alsa-devel][PATCH 3/4] ASoC: wm8960: add kcontrol to select ADC data output Zidan Wang
2015-06-12 12:29 ` Charles Keepax
2015-06-11 11:14 ` [alsa-devel][PATCH 4/4] ASoC: wm8960: the enum of "DAC Polarity" should be wm8960_enum[1] Zidan Wang
2015-06-12 12:31 ` Charles Keepax
2015-06-12 13:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612103349.GE1921@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=zidan.wang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox