From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [asoc:topic/topology 104/105] :undefined reference to `snd_soc_dapm_new_control' Date: Mon, 15 Jun 2015 11:12:05 +0530 Message-ID: <20150615054205.GR28601@localhost> References: <201506041837.OFTVnhYj%fengguang.wu@intel.com> <20150604120418.GE14071@sirena.org.uk> <1433427189.19747.53.camel@loki> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by alsa0.perex.cz (Postfix) with ESMTP id 938B026068D for ; Mon, 15 Jun 2015 07:40:36 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1433427189.19747.53.camel@loki> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: kbuild test robot , alsa-devel@alsa-project.org, Mark Brown , kbuild-all@01.org List-Id: alsa-devel@alsa-project.org On Thu, Jun 04, 2015 at 03:13:09PM +0100, Liam Girdwood wrote: > On Thu, 2015-06-04 at 13:04 +0100, Mark Brown wrote: > > On Thu, Jun 04, 2015 at 06:58:38PM +0800, kbuild test robot wrote: > > > > > All error/warnings (new ones prefixed by >>): > > > > > > sound/built-in.o: In function `soc_tplg_dapm_widget_create': > > > >> :(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control' > > > > The fix for the build bug in your patch exporting this was to add a > > static prototype (you were in the CC for that fix) so now the topology > > code still doesn't have the export. > > > > Can you send a fixup please? > > Sorry, appended below. I can resend separately if required. I dont think Mark applied this, can you please resend -- ~Vinod > > > From 3df449a45fcde9f63dd34683d4216a73bd900f98 Mon Sep 17 00:00:00 2001 > From: Liam Girdwood > Date: Thu, 4 Jun 2015 15:08:34 +0100 > Subject: [PATCH] ASoC: DAPM: fix build errors for missing > snd_soc_dapm_new_control symbol > > Fix the following error:- > > All error/warnings (new ones prefixed by >>): > > > > sound/built-in.o: In function `soc_tplg_dapm_widget_create': > > >> :(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control' > > Signed-off-by: Liam Girdwood > --- > sound/soc/soc-dapm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c > index 92d57a9..1b4a6eb 100644 > --- a/sound/soc/soc-dapm.c > +++ b/sound/soc/soc-dapm.c > @@ -53,7 +53,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm, > int (*connected)(struct snd_soc_dapm_widget *source, > struct snd_soc_dapm_widget *sink)); > > -static struct snd_soc_dapm_widget * > +struct snd_soc_dapm_widget * > snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm, > const struct snd_soc_dapm_widget *widget); > > @@ -3270,7 +3270,7 @@ int snd_soc_dapm_put_pin_switch(struct snd_kcontrol *kcontrol, > } > EXPORT_SYMBOL_GPL(snd_soc_dapm_put_pin_switch); > > -static struct snd_soc_dapm_widget * > +struct snd_soc_dapm_widget * > snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm, > const struct snd_soc_dapm_widget *widget) > { > -- > 2.1.4 > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel --