Re: [PATCH v2 1/2] ASoC: soc-compress: add a config item for soc-compress

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1332 bytes --]

On Wed, Jun 17, 2015 at 09:52:56PM +0530, Vinod Koul wrote:
> On Wed, Jun 17, 2015 at 01:23:40PM +0100, Mark Brown wrote:

> > I'm not sure this fully helps.  This will put the reference in the CPU
> > driver which if there's sharing with non-compressed DAIs means that any
> > machine driver using the platform needs to select the compressed audio
> > code.  It also means that we're still in the situation whre if a machine
> > *can* support compressed audio it *must* support compressed audio, it's
> > not clear to me that people doing this sort of memory optimisation are
> > always going to be doing it on hardware that doesn't have the capacity
> > for compressed audio (or won't in the future).  But then I don't know
> > exactly how much memory is being saved here...

> Yes this is a good point but then driver can define the compressed dai only
> when SND_SOC_COMPRESS is enabled. So if machine has enabled this symbol then
> only dai get added and machine can create dai-link

Well, if it's a user configurable thing then the stubs start to make
sense - the driver defines the DAI and then the core doesn't bother to
instantiate it.

> Also for the size question, in sound-next we have 248KB soc-compress.o

How big is the actual code - that sounds like it's got the debug
symbols?  I suppose I should go look myself...

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]