From: Mark Brown <broonie@kernel.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Antti Palosaari <crope@iki.fi>, Ingo Molnar <mingo@redhat.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Anatol Pomozov <anatol.pomozov@gmail.com>
Subject: Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep
Date: Thu, 25 Jun 2015 15:29:08 +0100 [thread overview]
Message-ID: <20150625142908.GN14071@sirena.org.uk> (raw)
In-Reply-To: <558C0067.2000401@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Thu, Jun 25, 2015 at 06:21:43AM -0700, Arjan van de Ven wrote:
Please fix your mailer to word wrap within paragraphs.
> wouldn't it be better to use the mutex_lock_nested() and co to
> explicitly express your hierarchy?
That was one of my original suggestions - one of the problems with this
code is that it's very much been presented as "here's the solution", it
took a long time to even discover the problem they were trying to solve.
I don't know exactly what the issue is supposed to be here, AFAICT the
answers were about lock classes not about subclasses because apparently
it's essential that we use lock classes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-25 14:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 9:35 [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat
2015-06-25 9:35 ` [RFC PATCH 2/2] ASoC: rt5677: Add lockdep class to silence lockdep warnings Nicolas Boichat
2015-06-25 13:21 ` [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Arjan van de Ven
2015-06-25 14:29 ` Mark Brown [this message]
2015-06-25 15:03 ` Lars-Peter Clausen
2015-06-25 15:33 ` Mark Brown
2015-06-25 15:47 ` Lars-Peter Clausen
2015-06-25 16:08 ` Mark Brown
2015-06-26 3:16 ` Nicolas Boichat
2015-06-29 12:51 ` Nicolas Boichat
2015-06-29 12:59 ` Lars-Peter Clausen
2015-06-29 14:03 ` Nicolas Boichat
2015-06-29 14:18 ` Lars-Peter Clausen
2015-06-29 15:34 ` Mark Brown
2015-06-30 4:56 ` Nicolas Boichat
2015-06-30 11:02 ` [alsa-devel] " Lars-Peter Clausen
2015-06-29 14:22 ` Mark Brown
2015-06-29 14:35 ` Arjan van de Ven
2015-06-29 15:32 ` Mark Brown
2015-06-29 15:36 ` Arjan van de Ven
2015-06-29 16:02 ` Mark Brown
2015-06-29 14:19 ` Mark Brown
2015-06-25 14:49 ` Mark Brown
2015-06-25 15:59 ` Lars-Peter Clausen
2015-06-26 2:34 ` Nicolas Boichat
2015-06-26 8:31 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625142908.GN14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=arjan@linux.intel.com \
--cc=bardliao@realtek.com \
--cc=crope@iki.fi \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=mingo@redhat.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox