From: Dan Carpenter <dan.carpenter@oracle.com>
To: jeeja.kp@intel.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ALSA: hdac_ext: add hdac extended controller
Date: Fri, 26 Jun 2015 12:42:44 +0300 [thread overview]
Message-ID: <20150626094244.GA29672@mwanda> (raw)
Hello Jeeja KP,
The patch 0b00a5615dc4: "ALSA: hdac_ext: add hdac extended
controller" from Jun 11, 2015, leads to the following static checker
warning:
sound/hda/ext/hdac_ext_controller.c:47 snd_hdac_ext_bus_parse_capabilities()
warn: unsigned 'offset' is never less than zero.
sound/hda/ext/hdac_ext_controller.c:54 snd_hdac_ext_bus_parse_capabilities()
warn: unsigned 'cur_cap' is never less than zero.
sound/hda/ext/hdac_ext_controller.c
38 int snd_hdac_ext_bus_parse_capabilities(struct hdac_ext_bus *ebus)
39 {
40 unsigned int cur_cap;
41 unsigned int offset;
42 struct hdac_bus *bus = &ebus->bus;
43 unsigned int counter = 0;
44
45 offset = snd_hdac_chip_readl(bus, LLCH);
46
47 if (offset < 0)
^^^^^^^^^^
48 return -EIO;
49
50 /* Lets walk the linked capabilities list */
51 do {
52 cur_cap = _snd_hdac_chip_read(l, bus, offset);
53
54 if (cur_cap < 0)
^^^^^^^^^^^
55 return -EIO;
regards,
dan carpenter
reply other threads:[~2015-06-26 9:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626094244.GA29672@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox