From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 5/6] ASoC: Intel: Skylake: Add DSP module init and binding routines
Date: Wed, 29 Jul 2015 13:35:14 +0100 [thread overview]
Message-ID: <20150729123514.GD20130@sirena.org.uk> (raw)
In-Reply-To: <1437503040-7392-6-git-send-email-vinod.koul@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 884 bytes --]
On Tue, Jul 21, 2015 at 11:53:59PM +0530, Vinod Koul wrote:
> +int skl_bind_unbind_modules(struct skl_sst *ctx, struct skl_module_cfg
> + *src_module, struct skl_module_cfg *dst_module, bool bind)
> +{
> + dev_dbg(ctx->dev, "%s: src module_id = %d src_instance=%d\n",
> + __func__, src_module->id.module_id, src_module->id.instance_id);
> + dev_dbg(ctx->dev, "%s: dst_module=%d dst_instacne=%d\n", __func__,
> + dst_module->id.module_id, dst_module->id.instance_id);
> +
> + dev_dbg(ctx->dev, "src_module state = %d dst module state = %d\n",
> + src_module->m_state, dst_module->m_state);
> +
> + if (bind)
> + return skl_bind_modules(ctx, src_module, dst_module);
> + else
> + return skl_unbind_modules(ctx, src_module, dst_module);
> +}
I'm not sure I understand the purpose of this function - why not just
use the bind and unbind functions directly if they share nothing?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-07-29 12:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 18:23 [PATCH 0/6] ASoC: Intel: Skylake: Add DSP management routines Vinod Koul
2015-07-21 18:23 ` [PATCH 1/6] ASoC: Intel: Skylake: Add NHLT support to get BE config Vinod Koul
2015-07-23 16:41 ` Applied "ASoC: Intel: Skylake: Add NHLT support to get BE config" to the asoc tree Mark Brown
2015-07-21 18:23 ` [PATCH 2/6] ASoC: Intel: Skylake: Add dsp and ipc init helpers Vinod Koul
2015-07-23 16:41 ` Applied "ASoC: Intel: Skylake: Add dsp and ipc init helpers" to the asoc tree Mark Brown
2015-07-21 18:23 ` [PATCH 3/6] ASoC: Intel: Skylake: Add functions for DSP module configuration Vinod Koul
2015-07-29 12:33 ` Mark Brown
2015-07-29 16:50 ` Vinod Koul
2015-07-29 17:56 ` Mark Brown
2015-07-30 3:15 ` Vinod Koul
2015-07-30 19:01 ` Mark Brown
2015-07-31 4:53 ` Vinod Koul
2015-07-31 18:09 ` Mark Brown
2015-08-01 12:50 ` Vinod Koul
2015-07-21 18:23 ` [PATCH 4/6] ASoC: Intel: Skylake: Add helpers for SRC and converter modules Vinod Koul
2015-07-21 18:23 ` [PATCH 5/6] ASoC: Intel: Skylake: Add DSP module init and binding routines Vinod Koul
2015-07-29 12:35 ` Mark Brown [this message]
2015-07-29 16:55 ` Vinod Koul
2015-07-21 18:24 ` [PATCH 6/6] ASoC: Intel: Skylake: Add pipe management helpers Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729123514.GD20130@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox