From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Brian Austin <brian.austin@cirrus.com>,
Support Opensource <support.opensource@diasemi.com>,
alsa-devel@alsa-project.org, Anish Kumar <yesanishhere@gmail.com>,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>
Subject: Re: [PATCH 00/42] ASoC: Replace users of TLV_DB_RANGE_HEAD
Date: Fri, 7 Aug 2015 09:26:05 +0100 [thread overview]
Message-ID: <20150807082605.GE25225@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1438528810-23498-1-git-send-email-lars@metafoo.de>
On Sun, Aug 02, 2015 at 05:19:28PM +0200, Lars-Peter Clausen wrote:
> Usage of TLV_DB_RANGE_HEAD() is deprecated in favor of
> DECLARE_TLV_DB_RANGE(). The reason for this is that the former requires to
> specify the number of items inside the range container while the later is
> able to calculate this automatically and hence leaves less room for error.
>
> While non of the current users of TLV_DB_RANGE_HEAD() gets it wrong it
> still makes sense to clean this up since existing drivers are often used as
> templates for new drivers. As an added bonus the code is also slightly
> shorter.
>
> There are also a few drivers which use TLV_DB_RANGE_HEAD() with only a
> single sub-item. Those are updated to not use a range container at all
> since it is not necessary.
>
> Most of the conversion was auto-generated using the following coccinelle
> script:
>
> // <smpl>
> @@
> declarer name DECLARE_TLV_DB_RANGE;
> identifier tlv;
> constant x;
> @@
> -unsigned int tlv[] = {
> - TLV_DB_RANGE_HEAD(x),
> +DECLARE_TLV_DB_RANGE(tlv,
> ...
> -};
> +);
> // </smpl>
>
> - Lars
>
For the Wolfson parts:
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
prev parent reply other threads:[~2015-08-07 8:26 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 15:19 [PATCH 00/42] ASoC: Replace users of TLV_DB_RANGE_HEAD Lars-Peter Clausen
2015-08-02 15:19 ` [PATCH 01/42] ASoC: 88pm860x: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:32 ` Applied "ASoC: 88pm860x: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 02/42] ASoC: ab8500: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:32 ` Applied "ASoC: ab8500: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 03/42] ASoC: adau1373: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: adau1373: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 04/42] ASoC: alc5623: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: alc5623: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 05/42] ASoC: alc5632: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: alc5632: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 06/42] ASoC: cs42l52: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: cs42l52: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 07/42] ASoC: cs42l56: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: cs42l56: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 08/42] ASoC: cs42l73: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: cs42l73: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 09/42] ASoC: da7210: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-03 14:45 ` Opensource [Adam Thomson]
2015-08-05 12:31 ` Applied "ASoC: da7210: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 10/42] ASoC: da7213: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-03 14:46 ` Opensource [Adam Thomson]
2015-08-05 12:31 ` Applied "ASoC: da7213: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 11/42] ASoC: da9055: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-03 14:47 ` Opensource [Adam Thomson]
2015-08-05 12:31 ` Applied "ASoC: da9055: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 12/42] ASoC: jz4740: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: jz4740: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 13/42] ASoC: max9768: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: max9768: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 14/42] ASoC: max98088: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: max98088: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 15/42] ASoC: max98090: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: max98090: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 16/42] ASoC: max98095: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: max98095: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 17/42] ASoC: max9850: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: max9850: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 18/42] ASoC: max9877: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: max9877: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 19/42] ASoC: rt5631: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: rt5631: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 20/42] ASoC: rt5640: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: rt5640: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 21/42] ASoC: rt5645: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: rt5645: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 22/42] ASoC: rt5651: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: rt5651: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 23/42] ASoC: rt5670: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: rt5670: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 24/42] ASoC: rt5677: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: rt5677: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 25/42] ASoC: sgtl5000: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: sgtl5000: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 26/42] ASoC: ssm2602: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: ssm2602: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 27/42] ASoC: tpa6130a2: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-03 13:38 ` Peter Ujfalusi
2015-08-05 12:31 ` Applied "ASoC: tpa6130a2: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 28/42] ASoC: twl4030: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-03 13:38 ` Peter Ujfalusi
2015-08-05 12:31 ` Applied "ASoC: twl4030: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 29/42] ASoC: uda1380: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: uda1380: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 30/42] ASoC: wm8350: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: wm8350: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:19 ` [PATCH 31/42] ASoC: wm8400: Don't use range container for TLV with one entry Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: wm8400: Don't use range container for TLV with one entry" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 32/42] ASoC: wm8737: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: wm8737: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 33/42] ASoC: wm8753: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: wm8753: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 34/42] ASoC: wm8961: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:31 ` Applied "ASoC: wm8961: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 35/42] ASoC: wm8962: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm8962: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 36/42] ASoC: wm8990: Don't use range container for TLV with one entry Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm8990: Don't use range container for TLV with one entry" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 37/42] ASoC: wm8991: Don't use range container for TLVs with one entry Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm8991: Don't use range container for TLVs with one entry" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 38/42] ASoC: wm8993: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm8993: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 39/42] ASoC: wm9081: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm9081: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 40/42] ASoC: wm9090: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm9090: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 41/42] ASoC: wm9713: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm9713: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-02 15:20 ` [PATCH 42/42] ASoC: wm_hubs: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE Lars-Peter Clausen
2015-08-05 12:30 ` Applied "ASoC: wm_hubs: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE" to the asoc tree Mark Brown
2015-08-03 12:03 ` [PATCH 00/42] ASoC: Replace users of TLV_DB_RANGE_HEAD Brian Austin
2015-08-07 8:26 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807082605.GE25225@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@ti.com \
--cc=support.opensource@diasemi.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox