From: Mark Brown <broonie@kernel.org>
To: yang.a.fang@intel.com
Cc: alsa-devel@alsa-project.org, srinivas.sripathi@intel.com,
Anish.Kumar@maximintegrated.com, praveen.k.jain@intel.com,
lgirdwood@gmail.com, denny.iriawan@intel.com,
sathyanarayana.nujella@intel.com, ullysses.a.eoff@intel.com,
kevin.strasser@linux.intel.com, dgreid@chromium.org
Subject: Re: [PATCH 1/2] ASoC: extend seq_notifier callback interface
Date: Fri, 7 Aug 2015 11:44:19 +0100 [thread overview]
Message-ID: <20150807104419.GN20873@sirena.org.uk> (raw)
In-Reply-To: <1438902946-49633-1-git-send-email-yang.a.fang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 521 bytes --]
On Thu, Aug 06, 2015 at 04:15:44PM -0700, yang.a.fang@intel.com wrote:
> From: "Fang, Yang A" <yang.a.fang@intel.com>
>
> This is needed for some codec driver to know whether
>
> it is power up/down sequence call from dapm
This isn't a good changelog - it's not enough to say what the change is,
you should (especially for a core change like this) be explaining why
the change is needed. For example in this case why do CODEC drivers
need this information?
You've also got a random blank line in there.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2015-08-07 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 23:15 [PATCH 1/2] ASoC: extend seq_notifier callback interface yang.a.fang
2015-08-06 23:15 ` [PATCH 2/2] ASoC: max98090: Enforce correct device sequencing when configuring a new yang.a.fang
2015-08-07 10:43 ` Mark Brown
2015-08-07 20:50 ` Fang, Yang A
2015-08-07 21:08 ` [PATCH v2] " yang.a.fang
2015-08-07 21:41 ` Anish Kumar
2015-08-10 12:00 ` Applied "ASoC: max98090: Fix sequencing when starting additional routes" to the asoc tree Mark Brown
2015-08-07 10:44 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807104419.GN20873@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Anish.Kumar@maximintegrated.com \
--cc=alsa-devel@alsa-project.org \
--cc=denny.iriawan@intel.com \
--cc=dgreid@chromium.org \
--cc=kevin.strasser@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=praveen.k.jain@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=srinivas.sripathi@intel.com \
--cc=ullysses.a.eoff@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox