Re: [PATCH 2/3] ASoC: fsl_sai: Add imx7d platform support

Zidan Wang
2015-08-10T02:25:15Z

On Fri, Aug 07, 2015 at 12:34:37PM -0700, Nicolin Chen wrote:
> On Fri, Aug 07, 2015 at 02:23:52PM +0800, Zidan Wang wrote:
> > i.MX7d SoC contains SAI module, so add imx7d platform support.
> >
> > Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
> > ---
> > sound/soc/fsl/fsl_sai.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> > index 5c737f1..390197e 100644
> > --- a/sound/soc/fsl/fsl_sai.c
> > +++ b/sound/soc/fsl/fsl_sai.c
> > @@ -704,6 +704,9 @@ static int fsl_sai_probe(struct platform_device *pdev)
> > if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx6sx-sai"))
> > sai->sai_on_imx = true;
> >
> > + if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx7d-sai"))
> > + sai->sai_on_imx = true;
>
> What's the difference between imx6sx-sai and imx7d-sai?
>
> I think you may put its compatible model in the DT instead of adding
> a copy in the driver unless the SAI on the imx7d really has something
> different.
>
> For example:
> compatible = "fsl,imx6q-ssi", "fsl,imx51-ssi";
> /* The driver only has imx51-ssi */

The imx7d-sai is the same as imx6sx-sai, so i should use compatible model "fsl,imx6sx-sai" for imx7d-sai.

Best Regards,
Zidan Wang