Re: Fwd: [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend)

Charles Keepax
2015-08-24T09:11:40Z

On Fri, Aug 21, 2015 at 02:09:46PM +0200, Christian Hartmann wrote:
> Hi
>
> 2015-08-21 9:43 GMT+02:00 Mika Westerberg <mika.westerberg@linux.intel.com>:
> > So please drop the code in 1) to be able to request the GPIO in the
> > driver.
>
> [ 6.129664] spi spi-WM510205:00: 8333333 Hz actual, PIO
> [ 6.129675] spi spi-WM510205:00: setup mode 0, 8 bits/w, 8000000 Hz max --> 0
> [ 6.129759] spi spi-WM510205:00: checking WM510205 with bmp180
> [ 6.129765] spi spi-WM510205:00: checking WM510205 with bmp181
> [ 6.129797] spi spi-WM510205:00: modalias WM510205 in id_table not
> found, returns NULL
> [ 6.129825] arizona spi-WM510205:00: arizona_acpi_get_type(), than
> via spi_get_device_id().
> [ 6.129831] arizona spi-WM510205:00: arizona_acpi_get_type matched
> [ 6.129836] arizona spi-WM510205:00: using 1 as type for arizona audio codec
> [ 6.129840] arizona spi-WM510205:00: regmap set to wm5102_spi
> [ 6.130630] arizona spi-WM510205:00: spi_irq = -1
> [ 6.130638] arizona spi-WM510205:00: acpi_dev_add_driver_gpios
> [ 6.144806] arizona spi-WM510205:00: found device ID: ffff
> [ 6.175352] arizona spi-WM510205:00: Unknown device ID ffff
> [ 6.175584] pxa2xx-spi 80860F0E:00: registered child spi-WM510205:00
> [ 6.177870] sst-acpi 80860F28:00: No matching ASoC machine driver found
>
> as you said, I removed the code in 1) so the EBUSY error is gone.
>
> What is with the spi_irq = -1 ?? is this a problem here?

The IRQ needs pulled from the ACPI as well, having no IRQ
specified will not interfer with basic functionality of the
driver but will become a problem eventually.

Thanks,
Charles