From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH] ASoC: fsl_sai: fix no frame clk in master mode Date: Wed, 12 Aug 2015 02:19:17 -0700 Message-ID: <20150812091916.GA1512@Asurada> References: <2ec370890aca1bf5e8b796d7ebbfc95a0161980e.1439345935.git.zidan.wang@freescale.com> <20150812035317.GA3194@Asurada-CZ80> <20150812075914.GC21786@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by alsa0.perex.cz (Postfix) with ESMTP id 46B35260438 for ; Wed, 12 Aug 2015 11:19:26 +0200 (CEST) Received: by pawu10 with SMTP id u10so10771914paw.1 for ; Wed, 12 Aug 2015 02:19:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150812075914.GC21786@shlinux2> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Zidan Wang Cc: alsa-devel@alsa-project.org, timur@tabi.org, lgirdwood@gmail.com, tiwai@suse.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Wed, Aug 12, 2015 at 03:59:15PM +0800, Zidan Wang wrote: > On Tue, Aug 11, 2015 at 08:53:25PM -0700, Nicolin Chen wrote: > > On Wed, Aug 12, 2015 at 10:25:45AM +0800, Zidan Wang wrote: > > > After several open/close sai test with ctrl+c, there will be I/O error. > > > The SAI can't work anymore, can't recover. There will be no frame clock. > > > With adding the software reset in trigger stop, the issue can be fixed. > > > > It doesn't look like a decent fix to me. Is it the only fix that > > IC team suggests? And why put this reset in the trigger function. > > Your MEGA fast patch has already included a software reset in the > > PM runtime functions. When dealing with CTRL+C test cases, that > > software reset should have worked as well. > > > The MEGA fast patch add the suspend/resume function, but CTRL+C will not trigger suspend/resume function. > When CTRL+C, it will trigger stop and software reset SAI. > IC team suggest us to rest it, but I don't know if it's the only fix. You can try to add SET_RUNTIME_PM_OPS() and to see if the suspend function is called right after pressing ctrl+c.