alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Zidan Wang <zidan.wang@freescale.com>
Cc: fabio.estevam@freescale.com, alsa-devel@alsa-project.org,
	tiwai@suse.com, timur@tabi.org, broonie@kernel.org
Subject: Re: [PATCH] ASoC: fsl-asoc-card: add wm8960 support
Date: Thu, 13 Aug 2015 20:58:06 -0700	[thread overview]
Message-ID: <20150814035805.GA2180@Asurada> (raw)
In-Reply-To: <20150814022116.GA11145@shlinux2>

On Fri, Aug 14, 2015 at 10:21:18AM +0800, Zidan Wang wrote:

> > And there is a crucial problem I can imagine:
> >   Is it okay to set this bit while setting SD1_CLK PAD as one
> >   of other functions rather than SAI MCLK? -- Customers might
> >   keep your code as they also use SAI2 while using SD1_CLK PAD
> >   as a GPIO input.

> I just add a gpr node in device tree, if customer want to use SD1_CLK
> PAD as a GPIO input, remove the gpr node.

My question was whether setting this bit would cause a hardware
damage -- Customers might not notice your gpr node in the Device
Tree at all, not to mention the possibility of an accidental wrong
configurations.

And another reason I asked that is to find out if we can set these
bits anyway in the SoC level driver of imx6ul when this bit would
not cause anything dangerous and when there's no extra clock MUX
for the SAI MCLK between internal CCM and external clock source.

Nicolin

  reply	other threads:[~2015-08-14  3:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12  3:22 [PATCH] ASoC: fsl-asoc-card: add wm8960 support Zidan Wang
2015-08-12  3:42 ` Nicolin Chen
2015-08-12  4:45   ` Zidan Wang
2015-08-12  6:40     ` Nicolin Chen
2015-08-12  7:39       ` Zidan Wang
2015-08-12  9:03         ` Nicolin Chen
2015-08-12 22:27         ` Nicolin Chen
2015-08-14  2:21           ` Zidan Wang
2015-08-14  3:58             ` Nicolin Chen [this message]
2015-08-14  7:38               ` Zidan Wang
2015-08-14  9:22                 ` Nicolin Chen
2015-09-06 11:33                   ` Shawn Guo
2015-09-17  8:03                     ` Nicolin Chen
2015-09-18 13:19                       ` Shawn Guo
2015-09-19 17:50                         ` Nicolin Chen
2015-08-12 12:05 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150814035805.GA2180@Asurada \
    --to=nicoleotsuka@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=timur@tabi.org \
    --cc=tiwai@suse.com \
    --cc=zidan.wang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).