From: Mark Brown <broonie@kernel.org>
To: "Lin, Mengdong" <mengdong.lin@intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Girdwood, Liam R" <liam.r.girdwood@intel.com>
Subject: Re: [PATCH v2 05/10] ASoC: Add support for dummy DAI links and PCM runtimes
Date: Mon, 17 Aug 2015 11:39:56 -0700 [thread overview]
Message-ID: <20150817183955.GV10748@sirena.org.uk> (raw)
In-Reply-To: <F46914AEC2663F4A9BB62374E5EEF8F8480D114C@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 829 bytes --]
On Mon, Aug 17, 2015 at 10:01:16AM +0000, Lin, Mengdong wrote:
> These *dummy* links are not place holders of real physical links.
> So they cannot come from ACPI but from topology.
OK, so this is something that should have been apparent from the
changelog and if that's what's supposed to happen that shouldn be what
the code does - it needs to be limited to these software only links.
But honestly this just doesn't seem like the ideal design - what this
means is that we're going to need to have a dummy link in place for any
link that is defined by the topology which means that we've got a hard
coded limit in the drivers for this dynamically defined thing from the
firmware. It'd be much nicer if we just created the links from scratch
when we detect them in firmware rather than requiring these stubs.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-08-17 18:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 14:45 [PATCH v2 00/10] ASoC: support adding PCM dynamically from topology mengdong.lin
2015-08-10 14:45 ` [PATCH v2 01/10] ASoC: Change the PCM runtime array to a list mengdong.lin
2015-08-14 20:02 ` Mark Brown
2015-08-17 6:28 ` Lin, Mengdong
2015-08-10 14:46 ` [PATCH v2 02/10] ASoC: Define soc_init_dai_link() to wrap link intialization mengdong.lin
2015-08-10 14:47 ` [PATCH v2 03/10] ASoC: Change 2nd argument of soc_bind_dai_link() to DAI link pointer mengdong.lin
2015-08-10 14:47 ` [PATCH v2 04/10] ASoC: Implement DAI links in a list mengdong.lin
2015-08-10 14:47 ` [PATCH v2 05/10] ASoC: Add support for dummy DAI links and PCM runtimes mengdong.lin
2015-08-14 20:22 ` Mark Brown
2015-08-17 10:01 ` Lin, Mengdong
2015-08-17 18:39 ` Mark Brown [this message]
2015-08-10 14:48 ` [PATCH v2 06/10] ASoC: Bind new DAI links after probing components mengdong.lin
2015-08-10 14:48 ` [PATCH v2 07/10] ASoC: Support adding a DAI dynamically mengdong.lin
2015-08-10 14:48 ` [PATCH v2 08/10] ASoC: topology: Change pass number of DAI smaller than graph mengdong.lin
2015-08-10 14:48 ` [PATCH v2 09/10] ASoC: topology: Change stream formats to bitwise flag mengdong.lin
2015-08-14 20:34 ` Mark Brown
2015-08-15 7:37 ` Takashi Iwai
2015-08-15 13:49 ` Lin, Mengdong
2015-08-15 14:45 ` Takashi Iwai
2015-08-15 15:25 ` Lin, Mengdong
2015-08-15 16:50 ` Takashi Iwai
2015-08-15 16:51 ` Mark Brown
2015-08-17 10:05 ` Lin, Mengdong
2015-08-15 15:14 ` Mark Brown
2015-08-15 14:59 ` Mark Brown
2015-08-15 16:52 ` Takashi Iwai
2015-08-10 14:48 ` [PATCH v2 10/10] ASOC: topology: Add PCM DAIs dynamically when loading them mengdong.lin
2015-08-15 7:56 ` [PATCH v2 00/10] ASoC: support adding PCM dynamically from topology Lars-Peter Clausen
2015-08-15 15:50 ` Mark Brown
2015-08-17 6:13 ` Lin, Mengdong
2015-08-17 10:39 ` Liam Girdwood
2015-08-17 20:05 ` Mark Brown
2015-08-18 5:17 ` Lin, Mengdong
2015-08-18 5:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817183955.GV10748@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@intel.com \
--cc=mengdong.lin@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox