Re: [PATCH v2] ASoC: Handle multiple codecs with split playback / capture

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1147 bytes --]

On Thu, Aug 20, 2015 at 10:45:21AM -0500, Pierre-Louis Bossart wrote:
> On 8/19/15 10:32 AM, Ricard Wanderlof wrote:

> >+		/*
> >+		 * Skip CODECs which don't support the current stream type.
> >+		 * Otherwise, since the rate, channel, and format values will
> >+		 * zero in that case, we would have no usable settings left,
> >+		 * causing the resulting setup to fail.
> >+		 * At least one CODEC should match, otherwise we should have
> >+		 * bailed out on a higher level, since there would be no
> >+		 * CODEC to support the transfer direction in that case.
> >+		 */
> >+		if (!snd_soc_dai_stream_valid(rtd->codec_dais[i],
> >+					      substream->stream))

> Maybe I misunderstood but shouldn't there be some sort of verification that
> the codecs can use the same number of slots between playback and capture if
> they share the same LRCLK/FS? e.g. it's not uncommon to have 4 mic capture
> and 2 ch playback. If the capture and playback is handled by different chips
> you'd still need to maintain some level of consistency.

Yes, this was my point about it being hard to work out what's going on
with regard to things being shared.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]