From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zidan Wang Subject: Re: [PATCH] ASoC: fsl_sai: fix no frame clk in master mode Date: Fri, 21 Aug 2015 16:40:20 +0800 Message-ID: <20150821084018.GA11926@shlinux2> References: <2ec370890aca1bf5e8b796d7ebbfc95a0161980e.1439345935.git.zidan.wang@freescale.com> <20150812035317.GA3194@Asurada-CZ80> <20150812075914.GC21786@shlinux2> <20150812091916.GA1512@Asurada> <20150818020152.GA17381@shlinux2> <20150821074737.GA1796@Asurada> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0147.outbound.protection.outlook.com [157.56.111.147]) by alsa0.perex.cz (Postfix) with ESMTP id C6C532604C2 for ; Fri, 21 Aug 2015 11:51:40 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20150821074737.GA1796@Asurada> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Nicolin Chen Cc: alsa-devel@alsa-project.org, timur@tabi.org, lgirdwood@gmail.com, tiwai@suse.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Fri, Aug 21, 2015 at 12:47:37AM -0700, Nicolin Chen wrote: > On Tue, Aug 18, 2015 at 10:01:54AM +0800, Zidan Wang wrote: > > > > > > > After several open/close sai test with ctrl+c, there will be I/O error. > > > > > > The SAI can't work anymore, can't recover. There will be no frame clock. > > > > > > With adding the software reset in trigger stop, the issue can be fixed. > > > > > > It doesn't look like a decent fix to me. Is it the only fix that > > > > > IC team suggests? And why put this reset in the trigger function. > > > > > Your MEGA fast patch has already included a software reset in the > > > > > PM runtime functions. When dealing with CTRL+C test cases, that > > > > > software reset should have worked as well. > > > > > The MEGA fast patch add the suspend/resume function, but CTRL+C will not > > > > trigger suspend/resume function. > > > > When CTRL+C, it will trigger stop and software reset SAI. > > > > IC team suggest us to rest it, but I don't know if it's the only fix. > > > > You can try to add SET_RUNTIME_PM_OPS() and to see if the suspend > > > function is called right after pressing ctrl+c. > > > The runtime suspend function will be call after the power down time. So if i > > playback again before the power down time, runtime suspend will not be called. > > I see.. Can you provide me a test case to reproduce this issue? 1. aplay -Dhw:0 /unit_tests/audio8k16S.wav 2. ctrl+c Set SAI to master mode, then try it several times. Best Regards, Zidan Wang