From: Mark Brown <broonie@kernel.org>
To: Oder Chiou <oder_chiou@realtek.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
john.lin@realtek.com, woojoo.lee@samsung.com,
bardliao@realtek.com, flove@realtek.com
Subject: Re: [PATCH v2] ASoC: rt5645: Prevent the pop sound of the headphone while rebooting or shutdowning
Date: Thu, 27 Aug 2015 20:17:22 +0100 [thread overview]
Message-ID: <20150827191722.GK5313@sirena.org.uk> (raw)
In-Reply-To: <1440659691-1835-1-git-send-email-oder_chiou@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 611 bytes --]
On Thu, Aug 27, 2015 at 03:14:51PM +0800, Oder Chiou wrote:
> Add i2c shutdown function to prevent the pop sound of the headphone while
> the system is rebooting or shutdowning. It de-initials the jack detection
> function, and it cannot be turned off in _BIAS_OFF. If we don't de-initial
> it, the pop sound will be heard in the situation of powering off. And
> replace the related register settings from magic number to meaningful
> defined name.
A comment in the changelog is useful but I was really looking for one in
the code here so people don't need to dive into the logs to understand
what's going on.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-08-27 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 7:14 [PATCH v2] ASoC: rt5645: Prevent the pop sound of the headphone while rebooting or shutdowning Oder Chiou
2015-08-27 19:17 ` Mark Brown [this message]
2015-08-28 1:47 ` Oder Chiou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827191722.GK5313@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=woojoo.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox