From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v2 0/9] Add DSP topology management for SKL Date: Thu, 3 Sep 2015 13:44:54 +0530 Message-ID: <20150903081454.GU13546@localhost> References: <1439832404-12424-1-git-send-email-vinod.koul@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by alsa0.perex.cz (Postfix) with ESMTP id 58AA0260603 for ; Thu, 3 Sep 2015 10:12:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1439832404-12424-1-git-send-email-vinod.koul@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Mon, Aug 17, 2015 at 10:56:35PM +0530, Vinod Koul wrote: > The SKL driver does not code DSP topology in driver. With this series > the ASoC topology framework is used to parse the topology information > to create widgets, controls and route map for the FW topology. > > It adds routines for SKL DSP module configuration, compute resources > for modules, initialize and bind the pipe modules. It uses the SKL IPC > library added earlier to send IPC for initialize the module, bind/unbind > modules. > Last patch in this series removes the unused dais. Hi Mark, I was wondering if you have any feedback on this series ? Thanks -- ~Vinod > > changes in v2: > - add more explanation in changelog and code > - add explanation of MCPS > - fix whitespace issues > - remove skl widget check on event handler as it is redundant > - add switch for depth > - add else for direction based code > - remove cast for NHLT blob query > - make debug prints to error > - remove dump info > - clean some debug prints > > Jeeja KP (9): > ASoC: Intel: Skylake: Add pipe and modules handlers > ASoC: Intel: Skylake: Add module configuration helpers > ASoC: Intel: Skylake: add DSP platform widget event handlers > ASoC: Intel: Skylake: Add FE and BE hw_params handling > ASoC: Intel: Skylake: Add topology core init and handlers > ASoC: Intel: Skylake: Initialize and load DSP controls > ASoC: Intel: Skylake: Add DSP support and enable it > ASoC: Intel: Skylake: Initialize NHLT table > ASoC: Intel: Skylake: Remove unused CPU dai's > > sound/soc/intel/skylake/Makefile | 3 +- > sound/soc/intel/skylake/skl-pcm.c | 171 ++-- > sound/soc/intel/skylake/skl-topology.c | 1262 ++++++++++++++++++++++++++ > sound/soc/intel/skylake/skl-topology.h | 21 + > sound/soc/intel/skylake/skl-tplg-interface.h | 78 ++ > sound/soc/intel/skylake/skl.c | 29 +- > sound/soc/intel/skylake/skl.h | 11 + > 7 files changed, 1507 insertions(+), 68 deletions(-) > create mode 100644 sound/soc/intel/skylake/skl-topology.c > > -- > 1.9.1 >