From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] ASoC: fsl-asoc-card: add wm8960 support Date: Sun, 6 Sep 2015 19:33:44 +0800 Message-ID: <20150906113344.GN30746@tiger> References: <20150812034257.GA2980@Asurada-CZ80> <20150812044505.GA21786@shlinux2> <20150812064053.GA2807@Asurada-CZ80> <20150812073859.GB21786@shlinux2> <20150812222735.GA57015@Asurada-CZ80> <20150814022116.GA11145@shlinux2> <20150814035805.GA2180@Asurada> <20150814073758.GB11145@shlinux2> <20150814092252.GA4164@Asurada-CZ80> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by alsa0.perex.cz (Postfix) with ESMTP id 9A74426156A for ; Sun, 6 Sep 2015 13:34:12 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20150814092252.GA4164@Asurada-CZ80> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Nicolin Chen Cc: fabio.estevam@freescale.com, alsa-devel@alsa-project.org, Zidan Wang , tiwai@suse.com, timur@tabi.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Fri, Aug 14, 2015 at 02:22:53AM -0700, Nicolin Chen wrote: > I have to add Shawn for help :) > > On Fri, Aug 14, 2015 at 03:38:16PM +0800, Zidan Wang wrote: > > > ccm ----->1------------------>2<------------>3 > > | | > > | | > > 4 SAIx MCLK1 5 SAIx MCLK2 > > > > If this bit is set, the clock route is ccm->1->2->3, 2 to 5 is disconnect. > > If this bit is clear, the clock route is 3->2->5, 1 to 2 is disconnect. > > @Shawn > > Suppose 1 and 2 are clock MUXs that we can't specifically touch > via registers. And 3 is an IO PAD that can either output a clock > from CCM or input a clock from an external source outside SoC. > Both 4 and 5 are two clock sources for one single SAI, SAI2 for > example. > > There is a bit in the GPR register to control above routes. And > my question is where should be the best place to put this bit. If this route selection is a decision of board design, it should fit device tree quite well. As the platform maintainer, I surely hope we can handle this in audio driver. But if there is really no place better than platform code to handle it, I can accept it. Shawn > > Apparently it's outside the CCM and SAI, not to mention it is > hard to relate this bit to this ASoC dai-link driver which's > supposed to solve problems between the SAI and CODECs. > > Thanks > Nicolin