From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH 4/4] ASoC: wm5110: Add additional analogue input enable for early revs
Date: Thu, 17 Sep 2015 09:10:07 +0100 [thread overview]
Message-ID: <20150917081007.GA7694@ck-lbox> (raw)
In-Reply-To: <20150916200159.GV12027@sirena.org.uk>
On Wed, Sep 16, 2015 at 09:02:00PM +0100, Mark Brown wrote:
> On Wed, Sep 16, 2015 at 01:59:43PM +0100, Charles Keepax wrote:
>
> > +static int wm5110_in_pga_get(struct snd_kcontrol *kcontrol,
> > + struct snd_ctl_elem_value *ucontrol)
> > +{
> > + struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
> > + struct snd_soc_dapm_context *dapm = snd_soc_codec_get_dapm(codec);
> > + struct snd_soc_card *card = dapm->card;
> > + int ret;
> > +
> > + mutex_lock_nested(&card->dapm_mutex, SND_SOC_DAPM_CLASS_RUNTIME);
> > +
> > + ret = snd_soc_get_volsw_range(kcontrol, ucontrol);
> > +
> > + mutex_unlock(&card->dapm_mutex);
>
> Can we please have a comment explaining why we need the lock (I see why
> but someone reading the code in the future might not)?
Yes no problem will fire a new version out today.
Thanks,
Charles
next prev parent reply other threads:[~2015-09-17 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 12:59 [PATCH 1/4] ASoC: arizona: Add default cases for event switches Charles Keepax
2015-09-16 12:59 ` [PATCH 2/4] ASoC: arizona: Add utility function to check if an input is analog Charles Keepax
2015-09-16 20:01 ` Applied "ASoC: arizona: Add utility function to check if an input is analog" to the asoc tree Mark Brown
2015-09-16 12:59 ` [PATCH 3/4] ASoC: Add SOC_SINGLE_RANGE_EXT_TLV macro Charles Keepax
2015-09-16 20:01 ` Applied "ASoC: Add SOC_SINGLE_RANGE_EXT_TLV macro" to the asoc tree Mark Brown
2015-09-16 12:59 ` [PATCH 4/4] ASoC: wm5110: Add additional analogue input enable for early revs Charles Keepax
2015-09-16 20:02 ` Mark Brown
2015-09-17 8:10 ` Charles Keepax [this message]
2015-09-16 20:01 ` Applied "ASoC: arizona: Add default cases for event switches" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917081007.GA7694@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).