From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 1/3] ASoC: wm0010: disable regulator on error
Date: Fri, 18 Sep 2015 12:34:12 +0100 [thread overview]
Message-ID: <20150918113412.GF7694@ck-lbox> (raw)
In-Reply-To: <1442572341-28201-1-git-send-email-sudipm.mukherjee@gmail.com>
On Fri, Sep 18, 2015 at 04:02:19PM +0530, Sudip Mukherjee wrote:
> We have done regulator_bulk_enable() while booting the DSP but on the
> error exit path we have not disbled it.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> sound/soc/codecs/wm0010.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
> index 8434d45..79a7cd3 100644
> --- a/sound/soc/codecs/wm0010.c
> +++ b/sound/soc/codecs/wm0010.c
> @@ -739,8 +739,6 @@ static int wm0010_boot(struct snd_soc_codec *codec)
> abort:
> /* Put the chip back into reset */
> wm0010_halt(codec);
> - mutex_unlock(&wm0010->lock);
> - return ret;
Does wm0010_halt not disable the regulators?
Thanks,
Charles
>
> err_core:
> mutex_unlock(&wm0010->lock);
> --
> 1.9.1
next prev parent reply other threads:[~2015-09-18 11:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 10:32 [PATCH 1/3] ASoC: wm0010: disable regulator on error Sudip Mukherjee
2015-09-18 10:32 ` [PATCH 2/3] ASoC: wm0010: fix memory leak Sudip Mukherjee
2015-09-18 11:39 ` Charles Keepax
2015-09-20 0:13 ` Applied "ASoC: wm0010: fix memory leak" to the asoc tree Mark Brown
2015-09-18 10:32 ` [PATCH 3/3] ASoC: wm0010: fix error path Sudip Mukherjee
2015-09-18 11:40 ` Charles Keepax
2015-09-20 0:13 ` Applied "ASoC: wm0010: fix error path" to the asoc tree Mark Brown
2015-09-18 11:34 ` Charles Keepax [this message]
2015-09-18 12:42 ` [PATCH 1/3] ASoC: wm0010: disable regulator on error Sudip Mukherjee
2015-09-18 12:38 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918113412.GF7694@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).